Skip to content

NO-ISSUE: Rebase main 4.19.0 with updates #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 5, 2024
Merged

NO-ISSUE: Rebase main 4.19.0 with updates #4259

merged 15 commits into from
Dec 5, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Dec 2, 2024

No description provided.

@pmtk pmtk changed the title Rebase main 4.19.0 0.nightly 2024 12 01 214857 amd64 2024 12 01 arm64 2024 11 28 Rebase main 4.19.0 with updates Dec 2, 2024
@openshift-ci openshift-ci bot requested review from copejon and ggiguash December 2, 2024 07:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@pmtk pmtk force-pushed the rebase-main-4.19.0-0.nightly-2024-12-01-214857_amd64-2024-12-01_arm64-2024-11-28 branch 4 times, most recently from ff12de9 to 46c43f5 Compare December 2, 2024 14:16
@pmtk
Copy link
Member Author

pmtk commented Dec 2, 2024

/test test-rebase

copejon
copejon reviewed Dec 2, 2024
View reviewed changes
test/scenarios-bootc/periodics/el94-crel@[email protected]
Comment on lines +8 to +11
if ! does_image_exist "${start_image}"; then
echo "Image '${start_image}' not found - skipping test"
return 0
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the image does not exist, could skipping this test mask a buildtime error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only if we don't catch the build time error. Shouldn't happen in CI, might be unnoticed in local dev env.
To do this "properly" we'd need a much more complicated mechanism to first decide if we should expect crel and then propagate it down to build and test phases.

@pmtk
Copy link
Member Author

pmtk commented Dec 3, 2024

/test ocp-full-conformance-serial-rhel-eus-arm

@pmtk
Copy link
Member Author

pmtk commented Dec 3, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

@pmtk: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-optional-components-rhel-eus

/test ocp-full-conformance-optional-components-rhel-eus-arm

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-rhel-eus-arm

/test ocp-full-conformance-serial-optional-components-rhel-eus

/test ocp-full-conformance-serial-optional-components-rhel-eus-arm

/test ocp-full-conformance-serial-rhel-eus

/test ocp-full-conformance-serial-rhel-eus-arm

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-ocp-full-conformance-optional-components-rhel-eus

pull-ci-openshift-microshift-main-ocp-full-conformance-optional-components-rhel-eus-arm

pull-ci-openshift-microshift-main-ocp-full-conformance-rhel-eus

pull-ci-openshift-microshift-main-ocp-full-conformance-rhel-eus-arm

pull-ci-openshift-microshift-main-ocp-full-conformance-serial-optional-components-rhel-eus

pull-ci-openshift-microshift-main-ocp-full-conformance-serial-optional-components-rhel-eus-arm

pull-ci-openshift-microshift-main-ocp-full-conformance-serial-rhel-eus

pull-ci-openshift-microshift-main-ocp-full-conformance-serial-rhel-eus-arm

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-rebase

pull-ci-openshift-microshift-main-test-rpm

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmtk
Copy link
Member Author

pmtk commented Dec 3, 2024

/test e2e-aws-tests-cache e2e-aws-tests-cache-arm

@pmtk
Copy link
Member Author

pmtk commented Dec 3, 2024

/test e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-bootc-periodic

@pmtk pmtk changed the title Rebase main 4.19.0 with updates NO-ISSUE: Rebase main 4.19.0 with updates Dec 3, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 3, 2024
@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk pmtk force-pushed the rebase-main-4.19.0-0.nightly-2024-12-01-214857_amd64-2024-12-01_arm64-2024-11-28 branch 2 times, most recently from 6ae22d0 to 0727e30 Compare December 3, 2024 15:29
@ggiguash
Copy link
Contributor

ggiguash commented Dec 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ddc2e7f and 2 for PR HEAD 0727e30f2bffa97ffa1df23351bf46b3c2c13ef2 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ddc2e7f and 2 for PR HEAD 0727e30f2bffa97ffa1df23351bf46b3c2c13ef2 in total

@pmtk
Copy link
Member Author

pmtk commented Dec 3, 2024

/test e2e-aws-tests-bootc-arm e2e-aws-tests-bootc-periodic-arm

@pmtk
Copy link
Member Author

pmtk commented Dec 3, 2024

/test e2e-aws-tests-bootc e2e-aws-tests-bootc-periodic

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ddc2e7f and 2 for PR HEAD 0727e30f2bffa97ffa1df23351bf46b3c2c13ef2 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ddc2e7f and 2 for PR HEAD 0727e30f2bffa97ffa1df23351bf46b3c2c13ef2 in total

@ggiguash ggiguash mentioned this pull request Dec 4, 2024
Closed
@pmtk
Copy link
Member Author

pmtk commented Dec 4, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1f5947 and 1 for PR HEAD 0727e30f2bffa97ffa1df23351bf46b3c2c13ef2 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
@pmtk pmtk force-pushed the rebase-main-4.19.0-0.nightly-2024-12-01-214857_amd64-2024-12-01_arm64-2024-11-28 branch from 8d4e09e to 2c01b8b Compare December 4, 2024 16:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@pmtk
Copy link
Member Author

pmtk commented Dec 4, 2024

/retest

@pmtk
Copy link
Member Author

pmtk commented Dec 5, 2024

/test e2e-aws-tests-cache e2e-aws-tests-cache-arm

@pmtk
Copy link
Member Author

pmtk commented Dec 5, 2024

/retest

@ggiguash
Copy link
Contributor

ggiguash commented Dec 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 33df884 into openshift:main Dec 5, 2024
25 checks passed
@pmtk pmtk deleted the rebase-main-4.19.0-0.nightly-2024-12-01-214857_amd64-2024-12-01_arm64-2024-11-28 branch December 6, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon copejon left review comments

@ggiguash ggiguash Awaiting requested review from ggiguash

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmtk @openshift-ci-robot @ggiguash @copejon @openshift-merge-robot