Skip to content

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Dec 13, 2024

The goal of this change is to complete the VM creation and test phase under 45m.

Periodic jobs may also be triggered in the PR, thus it's important to balance them out by having each test run under 30m.
CNCF is the longest periodic job taking ~2h, but it only runs in nightlies.

The following changes were implemented:

  • The osconfig tests that take 1.5h were split into 3 parts for ostree, similar to what already exists for bootc.
  • Reduced cos9 jobs number to improve the overall VM startup time and stability
    • Do not run osconfig tests on cos9, it's enough to test this on RHEL
    • Remove cos9 non-essential tests (e.g. backup, storage, log-scan, etc.) from presubmits
    • Move "special" configuration tests (e.g. multi-nic, optional, etc.) to periodics

The metal-tests stage now takes around 45m, which is ~15m for creating VMs and ~30m for running tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2024

@ggiguash: This pull request references USHIFT-5202 which is a valid jira issue.

In response to this:

The goal of this change is to complete the jobs until 1h30.

Periodic jobs may also be triggered in the PR, thus it's important to balance them out.
CNCF is the longest periodic job and it only runs in nightlies.

The following changes were implemented:

  • The osconfig tests that take 1.5h were split into 3 parts for ostree, similar to what already exists for bootc.
  • Reduced cos9 jobs number to improve the overall VM startup time and stability
  • Do not run osconfig tests on cos9, it's enough to test this on RHEL
  • Remove cos9 non-essential tests (e.g. backup, storage, log-scan, etc.) from presubmits
  • Move "special" configuration tests (e.g. multi-nic, optional, etc.) to periodics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
Copy link
Contributor Author

@ggiguash ggiguash Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: the diff of the following 3 files is misleading by looking like files were moved from bootc to ostree hierarchies. The logic of the change is to delete bootc cos9 osconfig tests and split ostree rhel osconfig tests into 3 parts.

@ggiguash
Copy link
Contributor Author

/test ?

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

@ggiguash: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test images
/test ocp-full-conformance-optional-components-rhel-eus
/test ocp-full-conformance-optional-components-rhel-eus-arm
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-rhel-eus-arm
/test ocp-full-conformance-serial-optional-components-rhel-eus
/test ocp-full-conformance-serial-optional-components-rhel-eus-arm
/test ocp-full-conformance-serial-rhel-eus
/test ocp-full-conformance-serial-rhel-eus-arm
/test test-rpm
/test test-unit
/test verify

The following commands are available to trigger optional jobs:

/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests
pull-ci-openshift-microshift-main-e2e-aws-tests-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
pull-ci-openshift-microshift-main-images
pull-ci-openshift-microshift-main-security
pull-ci-openshift-microshift-main-test-unit
pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests
/test e2e-aws-tests-periodic
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-periodic

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2024

@ggiguash: This pull request references USHIFT-5202 which is a valid jira issue.

In response to this:

The goal of this change is to complete the jobs under 1h30.

Periodic jobs may also be triggered in the PR, thus it's important to balance them out by having each test run under 30m.
CNCF is the longest periodic job and it only runs in nightlies.

The following changes were implemented:

  • The osconfig tests that take 1.5h were split into 3 parts for ostree, similar to what already exists for bootc.
  • Reduced cos9 jobs number to improve the overall VM startup time and stability
  • Do not run osconfig tests on cos9, it's enough to test this on RHEL
  • Remove cos9 non-essential tests (e.g. backup, storage, log-scan, etc.) from presubmits
  • Move "special" configuration tests (e.g. multi-nic, optional, etc.) to periodics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2024

@ggiguash: This pull request references USHIFT-5202 which is a valid jira issue.

In response to this:

The goal of this change is to complete the jobs under 1h30.

Periodic jobs may also be triggered in the PR, thus it's important to balance them out by having each test run under 30m.
CNCF is the longest periodic job taking ~2h, but it only runs in nightlies.

The following changes were implemented:

  • The osconfig tests that take 1.5h were split into 3 parts for ostree, similar to what already exists for bootc.
  • Reduced cos9 jobs number to improve the overall VM startup time and stability
  • Do not run osconfig tests on cos9, it's enough to test this on RHEL
  • Remove cos9 non-essential tests (e.g. backup, storage, log-scan, etc.) from presubmits
  • Move "special" configuration tests (e.g. multi-nic, optional, etc.) to periodics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash marked this pull request as ready for review December 13, 2024 10:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@openshift-ci openshift-ci bot requested review from agullon and pacevedom December 13, 2024 10:23
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2024

@ggiguash: This pull request references USHIFT-5202 which is a valid jira issue.

In response to this:

The goal of this change is to complete the jobs under 1h30.

Periodic jobs may also be triggered in the PR, thus it's important to balance them out by having each test run under 30m.
CNCF is the longest periodic job taking ~2h, but it only runs in nightlies.

The following changes were implemented:

  • The osconfig tests that take 1.5h were split into 3 parts for ostree, similar to what already exists for bootc.
  • Reduced cos9 jobs number to improve the overall VM startup time and stability
  • Do not run osconfig tests on cos9, it's enough to test this on RHEL
  • Remove cos9 non-essential tests (e.g. backup, storage, log-scan, etc.) from presubmits
  • Move "special" configuration tests (e.g. multi-nic, optional, etc.) to periodics

The metal-tests stage now takes around 45m, which is ~15m for creating VMs and ~30m for running tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2024

@ggiguash: This pull request references USHIFT-5202 which is a valid jira issue.

In response to this:

The goal of this change is to complete the VM creation and test phase under 45m.

Periodic jobs may also be triggered in the PR, thus it's important to balance them out by having each test run under 30m.
CNCF is the longest periodic job taking ~2h, but it only runs in nightlies.

The following changes were implemented:

  • The osconfig tests that take 1.5h were split into 3 parts for ostree, similar to what already exists for bootc.
  • Reduced cos9 jobs number to improve the overall VM startup time and stability
  • Do not run osconfig tests on cos9, it's enough to test this on RHEL
  • Remove cos9 non-essential tests (e.g. backup, storage, log-scan, etc.) from presubmits
  • Move "special" configuration tests (e.g. multi-nic, optional, etc.) to periodics

The metal-tests stage now takes around 45m, which is ~15m for creating VMs and ~30m for running tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc-periodic-arm

@pmtk
Copy link
Member

pmtk commented Dec 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd7309a and 2 for PR HEAD 4216b8d in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd7309a and 2 for PR HEAD 4216b8d in total

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc e2e-aws-tests-bootc-arm e2e-aws-tests-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc

1 similar comment
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd7309a and 2 for PR HEAD 4216b8d in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd7309a and 2 for PR HEAD 4216b8d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd7309a and 2 for PR HEAD 4216b8d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd7309a and 2 for PR HEAD 4216b8d in total

@ggiguash
Copy link
Contributor Author

/retest-required

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e8716b7 into openshift:main Dec 17, 2024
13 checks passed
@ggiguash ggiguash deleted the optimize_periodics branch December 18, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants