Skip to content

Conversation

microshift-rebase-script[bot]
Copy link
Contributor

amd64: 4.18.0-0.nightly-2025-01-13-114945
arm64: 4.18.0-0.nightly-arm64-2025-01-14-173318
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.18-rebase-on-nightlies/1879378180146466816

  • kubernetes image-arm64 205ac00c56dd2340b90dc0e328be84e77219197c to d93c78ae6fd13542228ed371626bee3c3e8d7e91
    • 5d18fcd9c 2024-12-11T15:40:47+00:00 UPSTREAM: : require configuration file enablement
    • a2bc30e98 2024-12-11T15:40:46+00:00 UPSTREAM: 126750: update comments
    • 08daca616 2024-12-11T15:40:46+00:00 UPSTREAM: 126750: Add takeByTopologyUnCoreCachePacked if policy option align-cpus-by-uncorecache is enabled. Adding new function to evaluate uncore cache id. Reverse allocation logic. Implement preferAlignByUncorecache within TakeByTopologyNUMAPacked, along with new test cases.

/label tide/merge-method-squash
/label cherry-pick-approved
/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2025
@openshift-ci-robot
Copy link

@microshift-rebase-script[bot]: This pull request explicitly references no jira issue.

In response to this:

amd64: 4.18.0-0.nightly-2025-01-13-114945
arm64: 4.18.0-0.nightly-arm64-2025-01-14-173318
prow job: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-microshift-release-4.18-rebase-on-nightlies/1879378180146466816

  • kubernetes image-arm64 205ac00c56dd2340b90dc0e328be84e77219197c to d93c78ae6fd13542228ed371626bee3c3e8d7e91
  • 5d18fcd9c 2024-12-11T15:40:47+00:00 UPSTREAM: : require configuration file enablement
  • a2bc30e98 2024-12-11T15:40:46+00:00 UPSTREAM: 126750: update comments
  • 08daca616 2024-12-11T15:40:46+00:00 UPSTREAM: 126750: Add takeByTopologyUnCoreCachePacked if policy option align-cpus-by-uncorecache is enabled. Adding new function to evaluate uncore cache id. Reverse allocation logic. Implement preferAlignByUncorecache within TakeByTopologyNUMAPacked, along with new test cases.

/label tide/merge-method-squash
/label cherry-pick-approved
/label backport-risk-assessed
/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 15, 2025
@openshift-ci openshift-ci bot requested review from pacevedom and pmtk January 15, 2025 04:12
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

@microshift-rebase-script[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: microshift-rebase-script[bot], pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8e6143b into release-4.18 Jan 15, 2025
13 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the rebase-release-4.18-4.18.0-0.nightly-2025-01-13-114945_amd64-2025-01-13_arm64-2025-01-14 branch January 15, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants