Skip to content

[release-4.18] USHIFT-5291: Remove CSI webhook due to deprecation #4436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

[release-4.18] USHIFT-5291: Remove CSI webhook due to deprecation #4436

merged 2 commits into from
Jan 23, 2025

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jan 20, 2025

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-5291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2025
@openshift-ci openshift-ci bot requested review from eslutsky and vanhalenar January 20, 2025 10:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@pmtk pmtk force-pushed the 4.18-remove-csi-webhook branch 5 times, most recently from efd38db to eb8d30b Compare January 21, 2025 14:30
@pmtk
Copy link
Member Author

pmtk commented Jan 21, 2025

/test test-rpm

@pmtk pmtk changed the title USHIFT-5291: Remove CSI webhook due to deprecation [release-4.18] USHIFT-5291: Remove CSI webhook due to deprecation Jan 22, 2025
ggiguash
ggiguash reviewed Jan 22, 2025
View reviewed changes
pkg/assets/scheme.go
@@ -27,4 +28,7 @@ func init() {
if err := sccv1.AddToScheme(scheme); err != nil {
panic(err)
}
if err := arv1.AddToScheme(scheme); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? Should we add a comment to explain?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary to make deletion of arv1.ValidatingWebhookConfiguration in deleteCSIWebhook working. Standard kubernetes+Go procedure

ggiguash
ggiguash reviewed Jan 22, 2025
View reviewed changes
pkg/components/csi-snapshot-controller.go Outdated
} else {
klog.Warningf("CSI snapshot webhook is disabled")
if err := deleteCSIWebhook(ctx, kubeconfigPath); err != nil {
klog.Warningf("Failed to delete resources of CSI Webhook, possibly corrupt state: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to speculate on the reason of the error in the message?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I just copied it from the storage.go where topolvm deletion is happening

@pmtk pmtk force-pushed the 4.18-remove-csi-webhook branch from eb8d30b to 4730f0b Compare January 22, 2025 09:23
@pmtk
Copy link
Member Author

pmtk commented Jan 22, 2025

/test ocp-full-conformance-serial-rhel-eus

@pmtk pmtk force-pushed the 4.18-remove-csi-webhook branch from 2ca9eb1 to 4730f0b Compare January 22, 2025 12:59
@pmtk
Copy link
Member Author

pmtk commented Jan 22, 2025

/retest

@pmtk pmtk force-pushed the 4.18-remove-csi-webhook branch from 4730f0b to b4c1a5d Compare January 22, 2025 16:11
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk pmtk mentioned this pull request Jan 23, 2025
Closed
pacevedom
pacevedom approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed
/label cherry-pick-approved
/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jan 23, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pacevedom
pacevedom reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2018187 into openshift:release-4.18 Jan 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eslutsky eslutsky Awaiting requested review from eslutsky

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

2 more reviewers

@pacevedom pacevedom pacevedom approved these changes

@ggiguash ggiguash ggiguash left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmtk @openshift-ci-robot @pacevedom @ggiguash