USHIFT-4288: Update greenboot.mds with healthcheck #4437
Conversation
|
@pmtk: This pull request references USHIFT-4288 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
|
||
| Then, executes `microshift healthcheck` command with following options: | ||
| - `-v=2` to increase verbosity of the output | ||
| - `--timeout="${WAIT_TIMEOUT_SECS}s"` to override default 300s timeout value |
There was a problem hiding this comment.
Is 300s the default in the code, or 600?
There was a problem hiding this comment.
It's 300s:
microshift/pkg/cmd/healthcheck.go
Line 67 in b7bde43
Co-authored-by: Gregory Giguashvili <[email protected]>
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.