Skip to content

[release-4.18] USHIFT-5291: Fix CNCF post CSI Webhook removal #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

[release-4.18] USHIFT-5291: Fix CNCF post CSI Webhook removal #4463

merged 1 commit into from
Jan 27, 2025

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jan 24, 2025

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 24, 2025 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-5291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 24, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@pmtk
Copy link
Member Author

pmtk commented Jan 24, 2025

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@pmtk: The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-serial-rhel-eus

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-arm

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-periodic

pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-release-4.18-images

pull-ci-openshift-microshift-release-4.18-security

pull-ci-openshift-microshift-release-4.18-test-unit

pull-ci-openshift-microshift-release-4.18-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmtk
Copy link
Member Author

pmtk commented Jan 24, 2025

/test e2e-aws-tests-bootc-periodic

@pmtk pmtk force-pushed the 4.18-fix-cncf-post-csi-webhook-removal branch from 62a4270 to 9a2c41f Compare January 27, 2025 07:52
@pmtk pmtk marked this pull request as ready for review January 27, 2025 07:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 January 27, 2025 07:52
pacevedom
pacevedom approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pacevedom
Copy link
Contributor

/label cherry-pick-approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jan 27, 2025
@ggiguash
Copy link
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a61a88f into openshift:release-4.18 Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmtk @openshift-ci-robot @pacevedom @ggiguash