USHIFT-4726: Attempt console login in offline tests #4481
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vanhalenar: This pull request references USHIFT-4726 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -622,7 +622,7 @@ launch_vm() { | |||
| vm_extra_args+=" inst.ks=file:/$(basename "${kickstart_file}")" | |||
| vm_initrd_inject+=" --initrd-inject ${kickstart_file}" | |||
| # Download and inject all the kickstart include files | |||
| wget -r -q -nd -A "*.cfg" -P "${kickstart_idir}" "$(dirname "${kickstart_url}")" | |||
| wget -r -q -nd -A "*.cfg" -P "${kickstart_idir}" "$(dirname "${kickstart_url}")/" | |||
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
The command would otherwise not work for me, it would redirect to the url with the slash but not download any files. This way it doesn't have to redirect.
There was a problem hiding this comment.
This is a bit strange as it's been working for some time already and it's not related to the current changes.
What's version of wget you have installed? This is what I have, for example.
GNU Wget 1.21.1 built on linux-gnu.
There was a problem hiding this comment.
I agree it is strange. I have GNU Wget2 2.2.0. I'll try downgrading then.
There was a problem hiding this comment.
Please, verify that it works for you in the older version with and without changes.
You're probably using Fedora, which has a newer wget version. I'm fine with this change - just need to make sure we're not breaking anything for RHEL 9.4 environments.
There was a problem hiding this comment.
I tested on Wget 1.21.4 on Fedora and it works fine with and without the slash.
There was a problem hiding this comment.
OK, so it's the new package update than that introduced this issue.
Let's merge it.
|
/test e2e-aws-tests-bootc-periodic |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, vanhalenar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@vanhalenar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I had to add a trailing slash to the
wgetcommand, because it would get redirected and wouldn't download the.cfgfiles otherwise, I'm not sure how it has worked so far.