Skip to content

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jan 28, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2025

@ggiguash: This pull request references USHIFT-5281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

See https://docs.ci.openshift.org/docs/how-tos/external-images/ for more information.
The CI changes are in openshift/release#61054

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@ggiguash ggiguash force-pushed the sync_release_images branch from 342f2a6 to 8589d5c Compare January 29, 2025 08:06
@ggiguash ggiguash marked this pull request as draft January 29, 2025 11:55
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2025
@ggiguash ggiguash force-pushed the sync_release_images branch from 8589d5c to 8dc122f Compare January 29, 2025 16:01
@ggiguash ggiguash marked this pull request as ready for review January 29, 2025 16:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025

@ggiguash: This pull request references USHIFT-5281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

See https://docs.ci.openshift.org/docs/how-tos/external-images/ for more information.
The CI changes are in openshift/release#61099

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash marked this pull request as draft January 30, 2025 08:21
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
@ggiguash ggiguash force-pushed the sync_release_images branch from 168ff34 to 0851337 Compare January 30, 2025 09:49
@ggiguash ggiguash marked this pull request as ready for review February 6, 2025 12:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
@openshift-ci openshift-ci bot requested review from agullon and jerpeter1 February 6, 2025 12:05
Comment on lines +2 to +3
BASE_IMAGE_URL ?= quay.io/centos/centos
BASE_IMAGE_TAG ?= stream9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have that split? Can we put it in single var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because otherwise it cannot be used in FROM as a variable.

@ggiguash ggiguash requested a review from pmtk February 7, 2025 09:18
@pmtk
Copy link
Member

pmtk commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a680cef into openshift:main Feb 7, 2025
10 checks passed
@ggiguash ggiguash deleted the sync_release_images branch February 8, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants