Skip to content

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Feb 18, 2025

This should not interfere with ART pipelines because those are not using MicroShift build_rpms.sh script.

@openshift-ci-robot
Copy link

@ggiguash: This pull request explicitly references no jira issue.

In response to this:

This should not interfere with ART pipelines because those are not using MicroShift make file rules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@pmtk
Copy link
Member

pmtk commented Feb 18, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
@ggiguash ggiguash force-pushed the always_build_flannel branch from d3cff61 to a1b5e68 Compare February 18, 2025 08:42
@ggiguash
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
@ggiguash ggiguash force-pushed the always_build_flannel branch from a1b5e68 to cff62e8 Compare February 18, 2025 08:44
@ggiguash ggiguash changed the title NO-ISSUE: Enable flannel RPM builds by default in Makefile NO-ISSUE: Enable flannel RPM build by default in build_rpms.sh Feb 18, 2025
@pmtk
Copy link
Member

pmtk commented Feb 18, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash ggiguash closed this Feb 18, 2025
@ggiguash ggiguash deleted the always_build_flannel branch February 18, 2025 15:32
@ggiguash ggiguash restored the always_build_flannel branch February 24, 2025 08:07
@ggiguash ggiguash reopened this Feb 24, 2025
@ggiguash
Copy link
Contributor Author

The FIPS errors are not related to this PR changes. Overriding to save CI cylces.
/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-periodic

Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-periodic

In response to this:

The FIPS errors are not related to this PR changes. Overriding to save CI cylces.
/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-periodic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6d167f9 into openshift:main Feb 24, 2025
15 checks passed
@ggiguash ggiguash deleted the always_build_flannel branch March 4, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants