USHIFT-5402: Handle DUID in ipv6 test harness #4586
Conversation
|
@pacevedom: This pull request references USHIFT-5402 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
/test e2e-aws-tests-bootc |
pacevedom
force-pushed
the
USHIFT-5402
branch
from
da4e93d to
69dd524
Compare
| xargs nmcli --fields DHCP6.OPTION con show | \ | ||
| grep dhcp6_client_id | \ | ||
| awk '{print $4}' | \ | ||
| uniq) |
There was a problem hiding this comment.
Do you think converting it to a for-loop would be more straightforward?
Also, the uniq is a bit confusing - may the process return more than one DUID? If yes, we need to handle it in the code. If not, a break in the for-loop could do the job.
There was a problem hiding this comment.
Not sure if the for loop would be more confusing, after all its iterating over all connections to determine which one is using DHCPv6 and take the id from there. This one liner does it in one shot. There is usually not more than 1 or 2 NICs in a single test, so most times this would be a single-iteration loop.
About the uniq: there is only one DUID per host, but if there is more than one NIC connected to ipv6 the command might return it multiple times. We know it must be the same because its system wide, hence the uniq to remove duplicates.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #