USHIFT-5401: Add telemetry configuration parameters #4600
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pacevedom: This pull request references USHIFT-5401 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
pacevedom
force-pushed
the
USHIFT-5401
branch
from
54f5821 to
7734ea6
Compare
|
/test e2e-aws-tests-arm |
|
/retest |
| @@ -18,3 +18,9 @@ else | |||
| MAIN_HOST_IP="$(hostname -I | awk '{print $1}')" | |||
| echo " - ${MAIN_HOST_IP}" >>/etc/microshift/config.yaml | |||
| fi | |||
|
|
|||
| # Configure MicroShift to not send telemetry data as default | |||
| cat - >>/etc/microshift/config.yaml <<EOF | |||
There was a problem hiding this comment.
Should we discuss this on the arch meeting? Would it not be interesting to see this info from CI?
There was a problem hiding this comment.
Yes, there will be a dedicated e2e test that will send metrics, so that should do it I guess? I will bring it up in the meeting.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #