Skip to content

USHIFT-5079: Add online AI Model Serving RF test #4662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2025
Merged

USHIFT-5079: Add online AI Model Serving RF test #4662

merged 4 commits into from
Mar 21, 2025

Conversation

agullon
Copy link
Contributor

@agullon agullon commented Mar 12, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2025 •
edited by openshift-ci bot
Loading

@agullon: This pull request references USHIFT-5079 which is a valid jira issue.

In response to this:

Enhancement for AI Model Serving RF testing:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor Author

agullon commented Mar 12, 2025

/hold until #4614 PR is merged because this PR extends #4614 PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@openshift-ci openshift-ci bot requested review from dhensel-rh and ggiguash March 12, 2025 11:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@agullon agullon marked this pull request as draft March 12, 2025 16:36
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025 •
edited by openshift-ci bot
Loading

@agullon: This pull request references USHIFT-5079 which is a valid jira issue.

In response to this:

Enhancement for AI Model Serving RF testing:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 13, 2025
@agullon agullon marked this pull request as ready for review March 13, 2025 10:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2025
@agullon
Copy link
Contributor Author

agullon commented Mar 13, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@openshift-ci openshift-ci bot requested review from copejon and vanhalenar March 13, 2025 10:26
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 13, 2025
pmtk
pmtk reviewed Mar 14, 2025
View reviewed changes
test/suites/ai-model-serving/ai-model-serving-online.robot Outdated


*** Keywords ***
Deploy OpenVINO Server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deploy OpenVINO Server
Deploy OpenVINO Model Server

or Deploy OVMS Serving Runtime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go with a mix from your two suggestions: Deploy OpenVINO Serving Runtime wdyt?

test/suites/ai-model-serving/ai-model-serving-offline.robot Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this file should be renamed to ai-model-serving.robot and not be created?

  • updated the scenario script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmtk do you mean I should rename it from ai-model-serving-offline.robot to the original name ai-model-serving.robot?

pmtk
pmtk reviewed Mar 17, 2025
View reviewed changes
@agullon
Copy link
Contributor Author

agullon commented Mar 18, 2025

/retest-required

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Mar 18, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Mar 18, 2025

/test e2e-aws-tests-bootc

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@agullon: No presubmit jobs available for openshift/microshift@main

In response to this:

/test e2e-aws-tests-bootc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agullon
Copy link
Contributor Author

agullon commented Mar 18, 2025

/test e2e-aws-tests-bootc

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@agullon: No presubmit jobs available for openshift/microshift@main

In response to this:

/test e2e-aws-tests-bootc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agullon
Copy link
Contributor Author

agullon commented Mar 18, 2025

/test e2e-aws-tests-bootc

@agullon
Copy link
Contributor Author

agullon commented Mar 19, 2025

/retest-required

pmtk
pmtk reviewed Mar 19, 2025
View reviewed changes
@pmtk
Copy link
Member

pmtk commented Mar 20, 2025

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_microshift/4662/pull-ci-openshift-microshift-main-e2e-aws-tests-bootc/1902369798264721408/artifacts/e2e-aws-tests-bootc/openshift-microshift-e2e-metal-tests/artifacts/scenario-info/el96-src@ai-model-serving-online/log.html#s1-t1-k9-k1-k1

You need to install vim-common on the hypervisor instead in the VM/containerfile

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 20, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2025
@agullon
Copy link
Contributor Author

agullon commented Mar 20, 2025

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_microshift/4662/pull-ci-openshift-microshift-main-e2e-aws-tests-bootc/1902369798264721408/artifacts/e2e-aws-tests-bootc/openshift-microshift-e2e-metal-tests/artifacts/scenario-info/el96-src@ai-model-serving-online/log.html#s1-t1-k9-k1-k1

You need to install vim-common on the hypervisor instead in the VM/containerfile

Thanks, added in the last commit.

@agullon
Copy link
Contributor Author

agullon commented Mar 20, 2025

/retest-required

@pmtk
Copy link
Member

pmtk commented Mar 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 94db59f into openshift:main Mar 21, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhensel-rh dhensel-rh Awaiting requested review from dhensel-rh

@ggiguash ggiguash Awaiting requested review from ggiguash

@copejon copejon Awaiting requested review from copejon

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

2 more reviewers

@pmtk pmtk pmtk left review comments

@kasturinarra kasturinarra kasturinarra left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agullon @openshift-ci-robot @pmtk @kasturinarra @openshift-merge-robot