Skip to content

Conversation

ggiguash
Copy link
Contributor

The mirror_registry.sh script is run automatically on every build_bootc_images.sh invocation and the process takes ~1m after all the images were mirrored. This is annoying in development environment.

With the optimizations in the PR commits, the repetitive run time was brought down to 10-15s. Interestingly, the majority of time was taken by suboptimal find+chmod operations.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025

@ggiguash: This pull request references USHIFT-5406 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

The mirror_registry.sh script is run automatically on every build_bootc_images.sh invocation and the process takes ~1m after all the images were mirrored. This is annoying in development environment.

With the optimizations in the PR commits, the repetitive run time was brought down to 10-15s. Interestingly, the majority of time was taken by suboptimal find+chmod operations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/assign @pmtk

@openshift-ci openshift-ci bot requested review from agullon and pmtk March 13, 2025 15:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-bootc-periodic

@pmtk
Copy link
Member

pmtk commented Mar 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3da083c and 2 for PR HEAD 22e1eaa in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3da083c and 2 for PR HEAD 22e1eaa in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f1e409e and 2 for PR HEAD 22e1eaa in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f1e409e and 2 for PR HEAD 22e1eaa in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 47fd748 and 1 for PR HEAD 22e1eaa in total

@ggiguash
Copy link
Contributor Author

The failures in bootc periodics are due to router security tests, unrelated to the current changes.
/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-bootc-periodic-arm

Copy link
Contributor

openshift-ci bot commented Mar 15, 2025

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-bootc-periodic-arm

In response to this:

The failures in bootc periodics are due to router security tests, unrelated to the current changes.
/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-bootc-periodic-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Mar 15, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9c1252b into openshift:main Mar 15, 2025
13 checks passed
@ggiguash ggiguash deleted the optimize_mirror_images branch March 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants