-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-5406: Optimize mirror images operation for repetitive runs #4674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-5406: Optimize mirror images operation for repetitive runs #4674
Conversation
@ggiguash: This pull request references USHIFT-5406 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @pmtk |
/test e2e-aws-tests-bootc-periodic-arm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
1 similar comment
The failures in bootc periodics are due to router security tests, unrelated to the current changes. |
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-bootc-periodic-arm In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The
mirror_registry.sh
script is run automatically on everybuild_bootc_images.sh
invocation and the process takes ~1m after all the images were mirrored. This is annoying in development environment.With the optimizations in the PR commits, the repetitive run time was brought down to 10-15s. Interestingly, the majority of time was taken by suboptimal
find+chmod
operations.