USHIFT-4882: Bootc published image standard tests can now use public registry when available #4703
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ggiguash: This pull request references USHIFT-4882 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18.z" instead. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/retest-required |
1 similar comment
|
/retest-required |
| @@ -9,26 +9,24 @@ IMAGE_SIGSTORE_ENABLED=true | |||
|
|
|||
| scenario_create_vms() { | |||
| if [[ "${CURRENT_RELEASE_REPO}" == "" ]] ; then | |||
| # TODO: While 4.19-ec is not available, it needs to exit without an error. | |||
| # Empty string means there's no EC build yet, so the test needs to be skipped. | |||
There was a problem hiding this comment.
I think that eventually it would be nice to have some report of skipped tests so they're not hidden away.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.