Skip to content

Conversation

praveenkumar
Copy link
Contributor

This reverts commit 177391d.

So looks like flannel now require br_netfilter module to start as per https://github.com/flannel-io/flannel?tab=readme-ov-file#deploying-flannel-with-helm because kubernetes/kubernetes#123464, which means it would problem to run microshift in container. I might going to check much simpler CNI like what kind use https://github.com/kubernetes-sigs/kind/tree/main/images/kindnetd

I am reverting this to make sure main branch have working flannel plugin.

This reverts commit 177391d.

So looks like flannel now require br_netfilter module to start as per
https://github.com/flannel-io/flannel?tab=readme-ov-file#deploying-flannel-with-helm
because kubernetes/kubernetes#123464, which means it would problem
to run microshift in container. I might going to check much simpler CNI like what kind use
https://github.com/kubernetes-sigs/kind/tree/main/images/kindnetd

I am reverting this to make sure main branch have working flannel
plugin.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2025
@openshift-ci-robot
Copy link

@praveenkumar: This pull request explicitly references no jira issue.

In response to this:

This reverts commit 177391d.

So looks like flannel now require br_netfilter module to start as per https://github.com/flannel-io/flannel?tab=readme-ov-file#deploying-flannel-with-helm because kubernetes/kubernetes#123464, which means it would problem to run microshift in container. I might going to check much simpler CNI like what kind use https://github.com/kubernetes-sigs/kind/tree/main/images/kindnetd

I am reverting this to make sure main branch have working flannel plugin.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dhensel-rh and pacevedom March 26, 2025 10:20
@praveenkumar
Copy link
Contributor Author

/hold

I am testing this again on the container side and will remove hold once tested successfully

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2025
@praveenkumar
Copy link
Contributor Author

/unhold

tested and it works again with older version of flannel.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2025
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

@praveenkumar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eslutsky
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2025
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1697651 into openshift:main Mar 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants