Skip to content

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Mar 31, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2025

@pmtk: This pull request references USHIFT-5541 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from pacevedom and vanhalenar March 31, 2025 10:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2025
@pmtk pmtk force-pushed the stabilize-olm-test branch from fc6c887 to a26c3a7 Compare March 31, 2025 15:00
@pmtk
Copy link
Member Author

pmtk commented Mar 31, 2025

/retest

@@ -553,7 +553,7 @@ launch_vm() {
local network="default"
local vm_memory=4096
local vm_vcpus=2
local vm_disksize=20
local vm_disksize=25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not increase the total disk size because we should be OK with 5GB leftover for unallocated partition for LVMS.
Can we update the test/kickstart-templates/includes/main-prologue.cfg comment with the new partitioning? We can also consider removing the example if that would better support future changes.

@pmtk pmtk force-pushed the stabilize-olm-test branch 2 times, most recently from 03c2666 to e3a8f84 Compare April 1, 2025 08:10
@pmtk pmtk force-pushed the stabilize-olm-test branch from e3a8f84 to ba0d113 Compare April 1, 2025 08:16
@ggiguash
Copy link
Contributor

ggiguash commented Apr 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dc22a36 and 2 for PR HEAD ba0d113 in total

@pmtk
Copy link
Member Author

pmtk commented Apr 1, 2025

/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-bootc-periodic-arm ci/prow/e2e-aws-tests-periodic

Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-bootc-periodic-arm, ci/prow/e2e-aws-tests-periodic

In response to this:

/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-bootc-periodic-arm ci/prow/e2e-aws-tests-periodic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmtk
Copy link
Member Author

pmtk commented Apr 1, 2025

/test e2e-aws-tests-arm

Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 65752cf into openshift:main Apr 1, 2025
13 checks passed
@pmtk pmtk deleted the stabilize-olm-test branch April 1, 2025 13:48
@pmtk
Copy link
Member Author

pmtk commented Apr 14, 2025

/cherry-pick release-4.18

@openshift-cherrypick-robot

@pmtk: new pull request created: #4799

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants