Skip to content

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Apr 1, 2025

The following procedures were moved to the user-only part:

  • Build MicroShift Bootc Image
  • Run MicroShift Bootc Virtual Machine
  • Using Bootc Image Builder (BIB)
  • Appendix A: Embedding Container Images in Bootc Builds

The following procedures remain in the contributor-only part:

  • Run MicroShift Bootc Image using podman
  • Appendix A: Multi-Architecture Image Build
  • Appendix B: The rpm-ostree to Image Mode Upgrade Procedure

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@ggiguash: This pull request references USHIFT-5477 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

The following procedures remain in the contributor-only part:

  • Run MicroShift Bootc Image using podman
  • The rpm-ostree to Image Mode Upgrade Procedure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Apr 1, 2025

/assign @DanielFroehlich

@openshift-ci openshift-ci bot requested review from copejon and dhensel-rh April 1, 2025 07:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
@ggiguash ggiguash force-pushed the split-image-mode-doc branch from 862568a to 49557ed Compare April 1, 2025 07:09
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@ggiguash: This pull request references USHIFT-5477 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

The following procedures were moved to the user-only part:

  • Build MicroShift Bootc Image
  • Run MicroShift Bootc Virtual Machine
  • Using Bootc Image Builder (BIB)
  • Appendix A: Embedding Container Images in Bootc Builds
  • Appendix B: The rpm-ostree to Image Mode Upgrade Procedure

The following procedures remain in the contributor-only part:

  • Run MicroShift Bootc Image using podman
  • Appendix A: The rpm-ostree to Image Mode Upgrade Procedure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@ggiguash: This pull request references USHIFT-5477 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

The following procedures were moved to the user-only part:

  • Build MicroShift Bootc Image
  • Run MicroShift Bootc Virtual Machine
  • Using Bootc Image Builder (BIB)
  • Appendix A: Embedding Container Images in Bootc Builds

The following procedures remain in the contributor-only part:

  • Run MicroShift Bootc Image using podman
  • Appendix A: Multi-Architecture Image Build
  • Appendix B: The rpm-ostree to Image Mode Upgrade Procedure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash force-pushed the split-image-mode-doc branch 2 times, most recently from 95a0e91 to 3b99dfb Compare April 1, 2025 07:20
@ggiguash ggiguash force-pushed the split-image-mode-doc branch from d76c29d to def1ffd Compare April 1, 2025 07:21
Copy link
Contributor

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! I do have some suggestions.

EOFKS
```

### Create Virtual Machine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary reason of building an ISO is that I can simply put it onto an USB stick and boot my edge device from it.
For that to success, the kickstart needs also be embedded into the ISO, not injected using the hypervisor.
It would be nice if bib would be able to do this directly , but it looks like it cant, should we create an RFE?
The procedure to embedd the kickstart into the ISO is non-trivial, if this doc is correct:
https://access.redhat.com/solutions/60959

So about we change this to:

Suggested change
### Create Virtual Machine
### Option A: Embed the kickstart file into the ISO
To be able to boot e.g. a physical edge device from the ISO, the kickstart file needs to be embedded into the ISO image. Follow the instructions provided [here](https://access.redhat.com/solutions/60959) to do so.
Then you can put the ISO image onto an USB using a disk imager tool of your choice (see e.g. [here](https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/interactively_installing_rhel_from_installation_media/assembly_creating-a-bootable-installation-medium_rhel-installer)) and boot the edge device from it.
### Option B: Create Virtual Machine from the ISO
When testing using a virtual machine, the kickstart file can be injected at vm creation time using the following steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will simplify this to always include kickstart in ISO. That's easy with BIB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embedding will complicate things a bit because it's not a command line option and we'll have to create a configuration file.
I changed the order of chapters:

  • Kickstart file creation is coming before ISO image creation now
  • Kickstart file creation contains this reference to how embed kickstart into ISO

Would it be acceptable for this doc?

@ggiguash ggiguash force-pushed the split-image-mode-doc branch from 6f32840 to c106e25 Compare August 6, 2025 06:01
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk
Copy link
Member

pmtk commented Aug 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bee1f31 into openshift:main Aug 6, 2025
5 checks passed
@ggiguash ggiguash deleted the split-image-mode-doc branch August 6, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants