-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-5477: Split MicroShift Image Mode docs into user and contributor parts #4753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-5477: Split MicroShift Image Mode docs into user and contributor parts #4753
Conversation
@ggiguash: This pull request references USHIFT-5477 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @DanielFroehlich |
862568a
to
49557ed
Compare
@ggiguash: This pull request references USHIFT-5477 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ggiguash: This pull request references USHIFT-5477 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
95a0e91
to
3b99dfb
Compare
d76c29d
to
def1ffd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! I do have some suggestions.
EOFKS | ||
``` | ||
|
||
### Create Virtual Machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary reason of building an ISO is that I can simply put it onto an USB stick and boot my edge device from it.
For that to success, the kickstart needs also be embedded into the ISO, not injected using the hypervisor.
It would be nice if bib would be able to do this directly , but it looks like it cant, should we create an RFE?
The procedure to embedd the kickstart into the ISO is non-trivial, if this doc is correct:
https://access.redhat.com/solutions/60959
So about we change this to:
### Create Virtual Machine | |
### Option A: Embed the kickstart file into the ISO | |
To be able to boot e.g. a physical edge device from the ISO, the kickstart file needs to be embedded into the ISO image. Follow the instructions provided [here](https://access.redhat.com/solutions/60959) to do so. | |
Then you can put the ISO image onto an USB using a disk imager tool of your choice (see e.g. [here](https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/interactively_installing_rhel_from_installation_media/assembly_creating-a-bootable-installation-medium_rhel-installer)) and boot the edge device from it. | |
### Option B: Create Virtual Machine from the ISO | |
When testing using a virtual machine, the kickstart file can be injected at vm creation time using the following steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will simplify this to always include kickstart in ISO. That's easy with BIB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embedding will complicate things a bit because it's not a command line option and we'll have to create a configuration file.
I changed the order of chapters:
- Kickstart file creation is coming before ISO image creation now
- Kickstart file creation contains this reference to how embed kickstart into ISO
Would it be acceptable for this doc?
6f32840
to
c106e25
Compare
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following procedures were moved to the user-only part:
The following procedures remain in the contributor-only part: