Skip to content

Conversation

agullon
Copy link
Contributor

@agullon agullon commented Apr 4, 2025

Add 2 telemetry test cases:

  • MicroShift Fails to Report Metrics To Server: Telemetry Disabled
  • MicroShift Fails to Report Metrics To Server: Wrong Pull Secret

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2025

@agullon: This pull request references USHIFT-2575 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Add 2 telemetry test cases:

  • MicroShift Fails to Report Metrics To Server: Telemetry Disabled
  • MicroShift Fails to Report Metrics To Server: Wrong Pull Secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 April 4, 2025 10:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@agullon
Copy link
Contributor Author

agullon commented Apr 4, 2025

/hold until all PR form telemetry feature are merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2025
@agullon agullon changed the title USHIFT-2575: add 2 telemetry test cases Draft: USHIFT-2575: add 2 telemetry test cases Apr 14, 2025
@agullon agullon marked this pull request as draft April 14, 2025 10:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2025
@agullon agullon changed the title Draft: USHIFT-2575: add 2 telemetry test cases USHIFT-2575: add 2 telemetry test cases Apr 14, 2025
@agullon
Copy link
Contributor Author

agullon commented Apr 14, 2025

Rebase it to main after #4780 is merged

@agullon agullon marked this pull request as ready for review April 30, 2025 12:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2025
@agullon
Copy link
Contributor Author

agullon commented Apr 30, 2025

/hold until #4825 PR is merged

@openshift-ci openshift-ci bot requested review from dhensel-rh and pmtk April 30, 2025 12:33
@agullon
Copy link
Contributor Author

agullon commented May 6, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2025
@agullon
Copy link
Contributor Author

agullon commented May 8, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented May 8, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
Copy link
Contributor

openshift-ci bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b418762 into openshift:main May 9, 2025
13 checks passed
@agullon
Copy link
Contributor Author

agullon commented May 9, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot

@agullon: #4769 failed to apply on top of branch "release-4.19":

Applying: add 2 telemetry test cases
Using index info to reconstruct a base tree...
A	test/suites/standard2/telemetry.robot
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/suites/standard2/telemetry.robot deleted in HEAD and modified in add 2 telemetry test cases. Version add 2 telemetry test cases of test/suites/standard2/telemetry.robot left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 add 2 telemetry test cases

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

agullon added a commit to agullon/microshift that referenced this pull request May 9, 2025
agullon added a commit to agullon/microshift that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants