Skip to content

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Apr 15, 2025

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 15, 2025

@pmtk: This pull request references USHIFT-5544 which is a valid jira issue.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@pmtk pmtk force-pushed the otel-scrape-pods branch from 8aafdc4 to c547700 Compare April 15, 2025 15:29
@pmtk
Copy link
Member Author

pmtk commented Apr 16, 2025

/assign @copejon @agullon

@pmtk pmtk force-pushed the otel-scrape-pods branch from a854b92 to f96042d Compare April 16, 2025 08:05
@pmtk pmtk marked this pull request as ready for review April 16, 2025 08:06
@pmtk pmtk changed the title USHIFT-5544: Scrape Pods' metrics USHIFT-5544: OTEL/observability: scrape Pods' metrics Apr 16, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 April 16, 2025 08:08
@copejon
Copy link
Contributor

copejon commented Apr 21, 2025

el94 to el96src upgrades are failing with this in boot_and_run.log:
stderr=error: failed to get domain '<THE HOST>'

Edit: More from the test's boot_and_run.log file:

Starting install...
ERROR    Couldn't find kernel for install tree.

@pmtk
Copy link
Member Author

pmtk commented Apr 22, 2025

el94 to el96src upgrades are failing with this in boot_and_run.log: stderr=error: failed to get domain '<THE HOST>'

Edit: More from the test's boot_and_run.log file:

Starting install...
ERROR    Couldn't find kernel for install tree.

Yes, that's something unrelated

@pmtk
Copy link
Member Author

pmtk commented Apr 22, 2025

/retest

@agullon
Copy link
Contributor

agullon commented Apr 22, 2025

Successfully tested. Looks good to me.

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 59d8d07 and 2 for PR HEAD f96042d in total

@pmtk
Copy link
Member Author

pmtk commented Apr 24, 2025

Failures are coming from crel jobs and crel is now broken (ec.5 unconditionally incorporated failing rebase).

/override ci/prow/e2e-aws-tests ci/prow/e2e-aws-tests-arm ci/prow/e2e-aws-tests-bootc ci/prow/e2e-aws-tests-bootc-arm

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-arm, ci/prow/e2e-aws-tests-bootc, ci/prow/e2e-aws-tests-bootc-arm

In response to this:

Failures are coming from crel jobs and crel is now broken (ec.5 unconditionally incorporated failing rebase).

/override ci/prow/e2e-aws-tests ci/prow/e2e-aws-tests-arm ci/prow/e2e-aws-tests-bootc ci/prow/e2e-aws-tests-bootc-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ef344d1 into openshift:main Apr 24, 2025
10 checks passed
@pmtk pmtk deleted the otel-scrape-pods branch April 24, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants