Skip to content

USHIFT-5621: qemu-ga tweaks: add timeouts, increase read file buffer, use subprocess lib #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

USHIFT-5621: qemu-ga tweaks: add timeouts, increase read file buffer, use subprocess lib #4821

merged 4 commits into from
Apr 23, 2025

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Apr 22, 2025

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmtk
Copy link
Member Author

pmtk commented Apr 22, 2025

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

@pmtk: The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-serial-rhel-eus

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2025
@pmtk
Copy link
Member Author

pmtk commented Apr 22, 2025

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic e2e-aws-tests-periodic-arm

@pmtk pmtk changed the title Qemu ga tweaks USHIFT-5621: Qemu ga tweaks Apr 22, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-5621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk pmtk changed the title USHIFT-5621: Qemu ga tweaks USHIFT-5621: qemu-ga tweaks: add timeouts & increase read file buffer Apr 22, 2025
@pmtk
Copy link
Member Author

pmtk commented Apr 22, 2025

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic e2e-aws-tests-periodic-arm

1 similar comment
@pmtk
Copy link
Member Author

pmtk commented Apr 23, 2025

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic e2e-aws-tests-periodic-arm

@pmtk
Copy link
Member Author

pmtk commented Apr 23, 2025

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic e2e-aws-tests-periodic-arm

@pmtk pmtk changed the title USHIFT-5621: qemu-ga tweaks: add timeouts & increase read file buffer USHIFT-5621: qemu-ga tweaks: add timeouts, increase read file buffer, use subprocess lib Apr 23, 2025
@pmtk
Copy link
Member Author

pmtk commented Apr 23, 2025

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic e2e-aws-tests-periodic-arm

@pmtk
Copy link
Member Author

pmtk commented Apr 23, 2025

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic e2e-aws-tests-periodic-arm

@pmtk pmtk marked this pull request as ready for review April 23, 2025 11:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2025
@openshift-ci openshift-ci bot requested review from eslutsky and pacevedom April 23, 2025 11:21
@pmtk
Copy link
Member Author

pmtk commented Apr 23, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 01f9dcb into openshift:main Apr 23, 2025
13 checks passed
pacevedom
pacevedom reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pmtk pmtk deleted the qemu-ga-tweaks branch April 23, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eslutsky eslutsky Awaiting requested review from eslutsky

1 more reviewer

@pacevedom pacevedom pacevedom left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmtk @openshift-ci-robot @ggiguash @pacevedom