Skip to content

USHIFT-5626: Reenable all disabled tests after switching to RC packages #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 22, 2025
Merged

USHIFT-5626: Reenable all disabled tests after switching to RC packages #4904

merged 4 commits into from
May 22, 2025

Conversation

ggiguash
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2025 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-5626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from eslutsky and vanhalenar May 14, 2025 13:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
pacevedom
pacevedom reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also remove this exclude tag now: https://github.com/openshift/microshift/blob/main/test/suites/standard1/router.robot#L191

@ggiguash ggiguash force-pushed the switch-to-419-rc branch from 0fda1b5 to 45e8b85 Compare May 14, 2025 15:31
@ggiguash
Copy link
Contributor Author

/retest-required

@pacevedom
Copy link
Contributor

/retest

@ggiguash ggiguash changed the title USHIFT-5626: Update test framework to use 4.19 RC packages from the mirror USHIFT-5626: Reenable all disabled tests after switching to RC packages May 22, 2025
pacevedom
pacevedom reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 22, 2025
pacevedom
pacevedom approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a45eb9a and 2 for PR HEAD bdeb80f7b027a27fd6374c0565e696116b5a5a33 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e49b7c0 and 1 for PR HEAD bdeb80f7b027a27fd6374c0565e696116b5a5a33 in total

@ggiguash ggiguash force-pushed the switch-to-419-rc branch from bdeb80f to 9449e2c Compare May 22, 2025 10:26
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
pacevedom
pacevedom approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 55b02c7 into openshift:main May 22, 2025
13 checks passed
@ggiguash ggiguash deleted the switch-to-419-rc branch June 4, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eslutsky eslutsky Awaiting requested review from eslutsky

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @pacevedom