USHIFT-5775: TLS config RF test: skip cipher if not available

[agullon]

Added a condition to skip checking a cipher when it's not available, for example, when FIPS mode is enabled.

[openshift-ci-robot]

@agullon: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@agullon: This pull request references USHIFT-5775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@agullon: This pull request references USHIFT-5775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Added a condition to skip checking a cipher when it's not available, for example, when FIPS mode is enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pacevedom]

/lgtm
/hold
Just one nit, held in case you want to do it. If not we can always do it later as its not critical and we are a bit tight on schedule.

[pacevedom]

Nit: If you default expected_str to empty string then you shouldnt need the IF below, right? Would also wouldnt require some string regardless of the rc when you call it (like in 194 below).

[agullon]

We shouldn't remove the IF because it's needed to validate the cipher under tests is in the stdout of the openssl command. See this line: https://github.com/openshift/microshift/pull/4939/files#diff-af253f15d1596775b3ca9cf4154438c05a0007533c49259a222eb7f9d4adc9aaR184

Furthermore, I'm happy to set the default value of ${expected_str} to an empty string, but I prefer to be not use default values on testing functions to force user to configure everything making sure what is being tested.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [agullon,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agullon]

/hold cancel

[agullon]

/cherrypick release-4.19

[openshift-cherrypick-robot]

@agullon: #4939 failed to apply on top of branch "release-4.19":

Applying: feature: skip cipher check if not available in ssl list
Using index info to reconstruct a base tree...
A	test/suites/standard2/tls-configuration.robot
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/suites/standard2/tls-configuration.robot deleted in HEAD and modified in feature: skip cipher check if not available in ssl list. Version feature: skip cipher check if not available in ssl list of test/suites/standard2/tls-configuration.robot left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feature: skip cipher check if not available in ssl list

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.