Skip to content

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented May 27, 2025

PR adds --plugin-env=e2e.E2E_SKIP= arg to skip [sig-network] Services should be able to switch session affinity for NodePort service [LinuxOnly] [Conformance] [sig-network, Conformance] test.

--e2e-skip wasn't picked as an arg, because it cannot be used together with the mode:

Error: mode flag and e2e-focus/skip flags both provided and may cause unintended behavior

We found that the test is frequently getting stuck. Another fix would be to edit the images to add --max-time option to the curl command, but we'd have to create cncf conformance image for each of the Kubernetes minor versions.

Problem should be fixed in v1.33 kubernetes tests: kubernetes/kubernetes#129049

CNCF running in CI jobs is not used for the CNCF certification.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 27, 2025
@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

In response to this:

PR adds --plugin-env=e2e.E2E_SKIP= arg to skip [sig-network] Services should be able to switch session affinity for NodePort service [LinuxOnly] [Conformance] [sig-network, Conformance] test.

--e2e-skip wasn't picked as an arg, because it cannot be used together with the mode:

Error: mode flag and e2e-focus/skip flags both provided and may cause unintended behavior

We found that the test is frequently getting stuck. Another fix would be to edit the images to add --max-time option to the curl command.

Problem should be fixed in v1.33 kubernetes tests: kubernetes/kubernetes#129049

CNCF running in CI jobs is not used for the CNCF certification.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
Copy link
Contributor

openshift-ci bot commented May 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@pmtk
Copy link
Member Author

pmtk commented May 27, 2025

/test e2e-aws-tests-bootc-periodic e2e-aws-tests-periodic e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic-arm

@pmtk pmtk force-pushed the cncf-ignore-test/main branch from 85b1936 to bdddf4f Compare May 27, 2025 11:37
@pmtk pmtk marked this pull request as ready for review May 27, 2025 11:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@openshift-ci openshift-ci bot requested review from ggiguash and vanhalenar May 27, 2025 11:38
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 27, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 032d259 into openshift:main May 27, 2025
13 checks passed
@pmtk pmtk deleted the cncf-ignore-test/main branch May 27, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants