Skip to content

Conversation

agullon
Copy link
Contributor

@agullon agullon commented Jun 3, 2025

Split rpm -V command check into 2 commands:

  • rpm -V --noconfig to check all files except config files
  • rpm -V --configfiles --nomtime to exclude modification time from only config files

This change is needed if, for example, a previous test modify a config file.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2025

@agullon: This pull request references USHIFT-5800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Split rpm -V command check into 2 commands:

  • rpm -V --noconfig to check all files except config files
  • rpm -V --configfiles --nomtime to exclude modification time from only config files

This change is needed if, for example, a previous test modify a config file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and pmtk June 3, 2025 10:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2025
@agullon
Copy link
Contributor Author

agullon commented Jun 3, 2025

/retest-required

7 similar comments
@agullon
Copy link
Contributor Author

agullon commented Jun 3, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jun 3, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jun 4, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jun 4, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jun 4, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jun 4, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2025

/retest-required

@pmtk
Copy link
Member

pmtk commented Jun 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2025
Copy link
Contributor

openshift-ci bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2025

/retest-required

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4fdf75c and 2 for PR HEAD d9f08aa in total

@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2025

/retest-required

2 similar comments
@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Jun 5, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b28d87e into openshift:main Jun 5, 2025
9 checks passed
@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot

@agullon: new pull request created: #5020

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants