-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-5800: rpm verify command only checks no modification time for no config files #5001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@agullon: This pull request references USHIFT-5800 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
7 similar comments
/retest-required |
/retest-required |
/retest-required |
/retest-required |
/retest-required |
/retest-required |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
1 similar comment
/retest-required |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
@agullon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherry-pick release-4.19 |
@agullon: new pull request created: #5020 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Split
rpm -V
command check into 2 commands:rpm -V --noconfig
to check all files except config filesrpm -V --configfiles --nomtime
to exclude modification time from only config filesThis change is needed if, for example, a previous test modify a config file.