Skip to content

OCPBUGS-57780: Fix signature checking in CI hypervisor #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

OCPBUGS-57780: Fix signature checking in CI hypervisor #5084

merged 1 commit into from
Jun 19, 2025

Conversation

pacevedom
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pacevedom
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

@pacevedom: The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-serial-rhel-eus

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@pacevedom
Copy link
Contributor Author

/test e2e-aws-tests-periodic
/test e2e-aws-tests-bootc-periodic

1 similar comment
@pacevedom
Copy link
Contributor Author

/test e2e-aws-tests-periodic
/test e2e-aws-tests-bootc-periodic

@pacevedom
Copy link
Contributor Author

/test e2e-aws-tests-periodic

@pacevedom pacevedom force-pushed the containers-policy branch from 5169f9b to 90f8845 Compare June 19, 2025 11:13
@pacevedom
Copy link
Contributor Author

/test e2e-aws-tests-periodic
/test e2e-aws-tests-bootc-periodic

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2025
@pacevedom pacevedom force-pushed the containers-policy branch from 90f8845 to dea80ff Compare June 19, 2025 12:45
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2025
@pacevedom pacevedom changed the title wip OCPBUGS-57780: Fix signature checking in CI hypervisor Jun 19, 2025
@pacevedom pacevedom marked this pull request as ready for review June 19, 2025 12:46
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 19, 2025
@openshift-ci-robot
Copy link

@pacevedom: This pull request references Jira Issue OCPBUGS-57780, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2025
@pacevedom
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 19, 2025
@openshift-ci-robot
Copy link

@pacevedom: This pull request references Jira Issue OCPBUGS-57780, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jogeo, copejon and dhensel-rh June 19, 2025 12:47
@pacevedom
Copy link
Contributor Author

/override ci/prow/test-unit
Overriding because the issue is unrelated to the change.

@pacevedom
Copy link
Contributor Author

/test verify

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/test-unit

In response to this:

/override ci/prow/test-unit
Overriding because the issue is unrelated to the change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacevedom
Copy link
Contributor Author

/test verify

@pacevedom pacevedom mentioned this pull request Jun 19, 2025
Closed
@ggiguash
Copy link
Contributor

/lgtm

@ggiguash
Copy link
Contributor

/test verify

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1fdfec0 and 2 for PR HEAD dea80ff in total

@pacevedom
Copy link
Contributor Author

/override ci/prow/verify

@pacevedom
Copy link
Contributor Author

/test e2e-aws-tests-bootc-periodic

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacevedom
Copy link
Contributor Author

/override ci/prow/e2e-aws-tests-bootc-periodic
Problem with ai-model-serving-offline unrelated to this PR.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/e2e-aws-tests-bootc-periodic

In response to this:

/override ci/prow/e2e-aws-tests-bootc-periodic
Problem with ai-model-serving-offline unrelated to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2025

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b72066d into openshift:main Jun 19, 2025
13 checks passed
@openshift-ci-robot
Copy link

@pacevedom: Jira Issue OCPBUGS-57780: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57780 has been moved to the MODIFIED state.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@copejon copejon Awaiting requested review from copejon

@dhensel-rh dhensel-rh Awaiting requested review from dhensel-rh

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacevedom @ggiguash @openshift-ci-robot