USHIFT-5862 USHIFT-5819: Golangci update and fixes #5095
Conversation
|
@pacevedom: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
/test e2e-aws-tests |
|
/test test-unit |
|
/test verify |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/override ci/prow/test-unit |
|
@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/test-unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ocp-full-conformance-rhel-eus |
pacevedom
changed the title
|
@pacevedom: This pull request references USHIFT-5862 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. This pull request references USHIFT-5819 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest |
|
/retest-required Remaining retests: 0 against base HEAD 844791b and 2 for PR HEAD b65a09c447608d2a061e119237aacacbb23b791a in total |
pacevedom
force-pushed
the
golangci-fixes
branch
from
b65a09c to
d8a83e8
Compare
pacevedom
force-pushed
the
golangci-fixes
branch
from
d8a83e8 to
46fadb4
Compare
pacevedom
force-pushed
the
golangci-fixes
branch
from
46fadb4 to
3191ce8
Compare
|
Tests are failing for the base-to-src upgrade. The base version picks up the head of the repo branch, which at this point is commit 844791bf9. This does not include the fixes for klog, so tests fail because MicroShift does not start properly. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacevedom, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-aws-tests |
|
/override ci/prow/e2e-aws-tests |
|
@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/e2e-aws-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-tests-arm |
|
/override ci/prow/e2e-aws-tests |
|
@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-arm, ci/prow/e2e-aws-tests-bootc, ci/prow/e2e-aws-tests-bootc-arm In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pacevedom: pacevedom unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/e2e-aws-tests-arm, ci/prow/e2e-aws-tests-bootc, ci/prow/e2e-aws-tests-bootc-arm In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-arm, ci/prow/e2e-aws-tests-bootc, ci/prow/e2e-aws-tests-bootc-arm In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #