Skip to content

USHIFT-5714 Update lvms-o to version 4.19.1 #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

USHIFT-5714 Update lvms-o to version 4.19.1 #5200

wants to merge 4 commits into from

Conversation

copejon
Copy link
Contributor

@copejon copejon commented Jul 15, 2025

No description provided.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2025
@openshift-ci openshift-ci bot requested review from agullon and eslutsky July 15, 2025 16:55
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025
pacevedom
pacevedom reviewed Jul 16, 2025
View reviewed changes
assets/release/release-aarch64.json Outdated
@@ -10,7 +10,7 @@
"ovn-kubernetes-microshift": "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:10e226538b18adf26a662ec0604d3359077e114bdac609195a89d49730e358b5",
"pod": "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:99b77b160a54c8b8b57bf8c1e2a7e8d33968a4fe9e2e322ae8ff0df924fdf0ba",
"service-ca-operator": "quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:837f35648549165bbd82a9bb3ca06e874b33da04229c8249a626503273c5d9be",
"lvms_operator": "registry.redhat.io/lvms4/lvms-rhel9-operator@sha256:0689e27defe411a07da33e339ec65df67e09a3a7080b8e5494fae5cb1a35db36",
"lvms_operator": "registry.redhat.io/lvms4/lvms-rhel9-operator@sha256:c857ffade720d157c11ad75e7d262a51966c169f7b0d519c82ffa12a4296db42",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the last_lvms_rebase.sh file, can you run it with the version in the PR's title? That should do everything for you.

@copejon copejon force-pushed the ushift-5714-2 branch 2 times, most recently from 2d45e45 to 413c60b Compare August 4, 2025 18:44
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2025
@copejon copejon force-pushed the ushift-5714-2 branch 2 times, most recently from 3c2f1b4 to 4ef37f3 Compare August 12, 2025 22:10
@copejon copejon force-pushed the ushift-5714-2 branch 3 times, most recently from b71fd0c to a827179 Compare August 19, 2025 23:18
@copejon copejon force-pushed the ushift-5714-2 branch 2 times, most recently from d9f5159 to c9043b1 Compare August 27, 2025 19:06
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2025
@copejon copejon changed the title USHIFT-5714 Update lvms-o to version 4.19.0-49 USHIFT-5714 Update lvms-o to version 4.19.1 Sep 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@copejon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-rebase 430f1cb link false /test test-rebase
ci/prow/e2e-aws-tests-bootc 430f1cb link true /test e2e-aws-tests-bootc
ci/prow/e2e-aws-tests-bootc-arm 430f1cb link true /test e2e-aws-tests-bootc-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pacevedom
Copy link
Contributor

Tested an additional commit on top of your whole PR and it worked well. There is some trouble with how the semver suffix is handled.
See #5410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agullon agullon Awaiting requested review from agullon

@eslutsky eslutsky Awaiting requested review from eslutsky

1 more reviewer

@pacevedom pacevedom pacevedom left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@copejon @pacevedom @openshift-merge-robot