Skip to content

USHIFT-5903: Improve user friendliness of healthcheck errors #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

USHIFT-5903: Improve user friendliness of healthcheck errors #5270

merged 2 commits into from
Aug 7, 2025

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jul 30, 2025

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 30, 2025 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-5903 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2025
@openshift-ci openshift-ci bot requested review from jogeo and pacevedom July 30, 2025 10:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@pmtk pmtk force-pushed the healthcheck-errors branch from c709e20 to 99d57a1 Compare July 30, 2025 11:06
@pmtk
Copy link
Member Author

pmtk commented Jul 30, 2025

/retest

@pmtk pmtk force-pushed the healthcheck-errors branch from 99d57a1 to 57e2077 Compare July 30, 2025 12:53
@pmtk
Copy link
Member Author

pmtk commented Jul 30, 2025

/retest

pacevedom
pacevedom reviewed Aug 6, 2025
View reviewed changes
@pmtk pmtk force-pushed the healthcheck-errors branch from 57e2077 to c4c8414 Compare August 6, 2025 09:36
pacevedom
pacevedom approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member Author

pmtk commented Aug 6, 2025

/test e2e-aws-tests-bootc-arm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ec0fb27 and 2 for PR HEAD c4c8414 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2fc6bf0 and 1 for PR HEAD c4c8414 in total

@pmtk
Copy link
Member Author

pmtk commented Aug 7, 2025

/test ocp-full-conformance-rhel-eus

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 632b914 and 0 for PR HEAD c4c8414 in total

@openshift-ci-robot
Copy link

/hold

Revision c4c8414 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2025
@pmtk
Copy link
Member Author

pmtk commented Aug 7, 2025

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 7, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3eec5d7 into openshift:main Aug 7, 2025
11 checks passed
@pmtk pmtk deleted the healthcheck-errors branch August 7, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmtk @openshift-ci-robot @pacevedom