USHIFT-5723: Add test to verify count in GDP config #5300

kasturinarra · 2025-08-07T18:46:01Z

Which issue(s) this PR addresses: Verify a Pod can request multiple instances of a device when count is specified in the GDP configuration.

Closes #

kasturinarra · 2025-08-13T19:02:14Z

@pmtk could you please help review ? thanks !!

pmtk · 2025-08-19T13:46:10Z

test/suites/optional/generic-device-plugin.robot

+Verify FUSE device allocation and accessibility
+    [Documentation]    Verifies FUSE device configuration, allocation, and accessibility in pods
+    [Tags]    fuse-device
+    Enable And Configure GDP    ${GDP_CONFIG_FUSE_COUNT}


Suggested change

Enable And Configure GDP ${GDP_CONFIG_FUSE_COUNT}

[Setup] Enable And Configure GDP ${GDP_CONFIG_FUSE_COUNT}

pmtk · 2025-08-19T13:47:22Z

test/suites/optional/generic-device-plugin.robot

+    Enable And Configure GDP    ${GDP_CONFIG_FUSE_COUNT}
+    Wait Until Device Is Allocatable    10    fuse
+    # Create and deploy pod requesting 4 FUSE devices
+    ${path}=    Create Random Temp File    ${POD_FUSE_DEVICE}


How about moving the string into a dedicated file in test/assets/generic-device-plugin/?

okay, i can do that.

pmtk · 2025-08-19T13:47:59Z

test/suites/optional/generic-device-plugin.robot

+    Oc Wait    -n ${NAMESPACE} pod/fuse-test-pod    --for=condition=Ready --timeout=120s
+
+    # Verify /dev/fuse is accessible in the pod
+    ${fuse_device}=    Run With Kubeconfig    oc exec -n ${NAMESPACE} fuse-test-pod -- ls -l /dev/fuse


We have Oc Exec keyword, can we use it instead?

pmtk · 2025-08-19T13:49:07Z

test/suites/optional/generic-device-plugin.robot

+    ${describe_output}=    Run With Kubeconfig    oc describe node ${node_name}
+    Should Contain    ${describe_output}    device.microshift.io/fuse:    10
+    Should Contain    ${describe_output}    device.microshift.io/fuse    4    4
+


Missing [Teardown]

Based on the test case i see i do not need individual teardown, since Teardown Suite With GDP Cleanup would be sufficient. Do i still need the Missing [Teardown] ?

pmtk · 2025-08-19T13:55:57Z

test/suites/optional/generic-device-plugin.robot

+    Should Contain    ${describe_output}    device.microshift.io/fuse:    10
+    Should Contain    ${describe_output}    device.microshift.io/fuse    4    4


There are 2+ spaces after fuse and numbers, this means they are separate arguments to the keyword

Should Contain ${describe_output} device.microshift.io/fuse 4 4 --- arg 1 ------- --- arg 2 ----------- arg3 arg4

You can see it in the execution log:

Arguments: [ ... | 'device.microshift.io/fuse' | '4' | '4' ]

I think it skips the fours and just matches the first string. I think we need to create string with 4 spaces inside in another way

openshift-ci-robot · 2025-08-20T08:01:16Z

@kasturinarra: This pull request references USHIFT-5723 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses: Verify a Pod can request multiple instances of a device when count is specified in the GDP configuration.

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kasturinarra · 2025-08-20T08:44:48Z

@pmtk addressed all your comments, could you please help review again ?

pmtk · 2025-08-20T08:56:06Z

test/suites/optional/generic-device-plugin.robot

+    VAR    ${path}=    ./assets/generic-device-plugin/fuse-test-pod.yaml
+    Oc Create    -f ${path} -n ${NAMESPACE}
+
+    # Wait for pod to be ready and verify device accessibility


I feel like this comment is redundant. "verify device accessibility" applies more to next block which has its own comment

pmtk · 2025-08-20T08:56:10Z

test/suites/optional/generic-device-plugin.robot

+    [Tags]    fuse-device
+    [Setup]    Enable And Configure GDP    ${GDP_CONFIG_FUSE_COUNT}
+    Wait Until Device Is Allocatable    10    fuse
+    # Create and deploy pod requesting 4 FUSE devices


I feel like this comment is redundant

pmtk · 2025-08-20T08:56:30Z

test/suites/optional/generic-device-plugin.robot

+    VAR    ${path}=    ./assets/generic-device-plugin/fuse-test-pod.yaml
+    Oc Create    -f ${path} -n ${NAMESPACE}


Suggested change

VAR ${path}= ./assets/generic-device-plugin/fuse-test-pod.yaml

Oc Create -f ${path} -n ${NAMESPACE}

Oc Create -f ./assets/generic-device-plugin/fuse-test-pod.yaml -n ${NAMESPACE}

pmtk · 2025-08-20T09:18:40Z

test/suites/optional/generic-device-plugin.robot

+    ${allocation_matches}=    Get Regexp Matches
+    ...    ${allocated_line}
+    ...    device\\.microshift\\.io/fuse\\s+(\\d+)\\s+(\\d+)
+    ...    1    2
+    Should Be Equal As Integers    ${allocation_matches}[0]    4
+    Should Be Equal As Integers    ${allocation_matches}[1]    4


This failed for me:

can you try again please ? I just updated it to the right way.

Verify FUSE device allocation and accessibility :: Verifies FUSE d... | PASS |

pmtk · 2025-08-20T15:59:05Z

/lgtm

openshift-ci · 2025-08-20T15:59:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-08-20T17:23:25Z

@kasturinarra: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from dhensel-rh and pacevedom August 7, 2025 18:46

kasturinarra changed the title ~~Test hot plugging of devices~~ [WIP] - Test hot plugging of devices Aug 7, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2025

kasturinarra force-pushed the autocase_83174 branch from 264513f to ebf5ecd Compare August 11, 2025 10:49

kasturinarra changed the title ~~[WIP] - Test hot plugging of devices~~ Add test to verify count in GDP config Aug 11, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2025

kasturinarra force-pushed the autocase_83174 branch from ebf5ecd to 31c38b0 Compare August 13, 2025 18:33

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2025

kasturinarra force-pushed the autocase_83174 branch from 31c38b0 to baf6fa9 Compare August 13, 2025 18:41

pmtk reviewed Aug 19, 2025

View reviewed changes

kasturinarra changed the title ~~Add test to verify count in GDP config~~ USHIFT-5723: Add test to verify count in GDP config Aug 20, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2025

kasturinarra force-pushed the autocase_83174 branch from baf6fa9 to ebdb11e Compare August 20, 2025 08:44

pmtk reviewed Aug 20, 2025

View reviewed changes

Add test to verify count in GDP config

f8b9a2d

kasturinarra force-pushed the autocase_83174 branch from ebdb11e to f8b9a2d Compare August 20, 2025 09:50

openshift-ci bot assigned pmtk Aug 20, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025

openshift-merge-bot bot merged commit 4ae6183 into openshift:main Aug 20, 2025
9 checks passed

	Enable And Configure GDP ${GDP_CONFIG_FUSE_COUNT}
	[Setup] Enable And Configure GDP ${GDP_CONFIG_FUSE_COUNT}

		Should Contain ${describe_output} device.microshift.io/fuse: 10
		Should Contain ${describe_output} device.microshift.io/fuse 4 4

		VAR ${path}= ./assets/generic-device-plugin/fuse-test-pod.yaml
		Oc Create -f ${path} -n ${NAMESPACE}

	VAR ${path}= ./assets/generic-device-plugin/fuse-test-pod.yaml
	Oc Create -f ${path} -n ${NAMESPACE}
	Oc Create -f ./assets/generic-device-plugin/fuse-test-pod.yaml -n ${NAMESPACE}

USHIFT-5723: Add test to verify count in GDP config #5300

USHIFT-5723: Add test to verify count in GDP config #5300

Uh oh!

Conversation

kasturinarra commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kasturinarra commented Aug 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Aug 20, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kasturinarra commented Aug 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kasturinarra Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kasturinarra Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmtk commented Aug 20, 2025

Uh oh!

openshift-ci bot commented Aug 20, 2025

Uh oh!

openshift-ci bot commented Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

kasturinarra commented Aug 7, 2025 •

edited

Loading

openshift-ci-robot commented Aug 20, 2025 •

edited by openshift-ci bot

Loading

kasturinarra Aug 20, 2025 •

edited

Loading

kasturinarra Aug 20, 2025 •

edited

Loading