-
Notifications
You must be signed in to change notification settings - Fork 216
Add HTTP01 ACME test for cert-manager #5320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kasturinarra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@eslutsky could you please help review ? thanks !! |
e9b49cb
to
52f744f
Compare
${subject_alt_names_line}= Get Lines Containing String ${config_content} subjectAltNames: | ||
${first_line}= Get Line ${subject_alt_names_line} 0 | ||
${alt_names_content}= Get Regexp Matches ${first_line} \\[(.+?)\\] 1 | ||
VAR ${alt_names_list}= ${alt_names_content}[0] | ||
# Get the first DNS name (before the first comma) | ||
${first_dns_name}= Split String ${alt_names_list} , 1 | ||
${dns_name}= Strip String ${first_dns_name}[0] | ||
Should Not Be Empty ${dns_name} msg=Failed to retrieve DNS name from MicroShift config | ||
RETURN ${dns_name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${subject_alt_names_line}= Get Lines Containing String ${config_content} subjectAltNames: | |
${first_line}= Get Line ${subject_alt_names_line} 0 | |
${alt_names_content}= Get Regexp Matches ${first_line} \\[(.+?)\\] 1 | |
VAR ${alt_names_list}= ${alt_names_content}[0] | |
# Get the first DNS name (before the first comma) | |
${first_dns_name}= Split String ${alt_names_list} , 1 | |
${dns_name}= Strip String ${first_dns_name}[0] | |
Should Not Be Empty ${dns_name} msg=Failed to retrieve DNS name from MicroShift config | |
RETURN ${dns_name} | |
${config_yaml}= Evaluate yaml.safe_load('''${config_content}''') modules=yaml | |
${first_dns_name}= Get From List ${config_yaml['apiServer']['subjectAltNames']} 0 | |
Should Not Be Empty ${first_dns_name} msg=Failed to retrieve DNS name from MicroShift config | |
RETURN ${first_dns_name} |
you can evalulate the config as yaml file and get the first item from subjectAltNames .
e017908
to
f686a50
Compare
f686a50
to
bfeef46
Compare
/test security |
/test e2e-aws-tests-arm |
/test e2e-aws-tests-bootc |
/test e2e-aws-tests-bootc-arm |
345336c
to
1172447
Compare
1172447
to
4f7de9b
Compare
4f7de9b
to
88ab792
Compare
@kasturinarra: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
🤖 Generated with Claude Code
Which issue(s) this PR addresses: Creating a local acme server to t
Closes #