Skip to content

Conversation

kasturinarra
Copy link

  • Add new test case for cert-manager with local ACME server (Pebble) using HTTP01 challenge
  • Include Pebble server deployment configuration
  • Add keywords for DNS name retrieval, certificate verification, and cleanup

🤖 Generated with Claude Code

Which issue(s) this PR addresses: Creating a local acme server to t

Closes #

@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 August 13, 2025 10:23
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasturinarra
Copy link
Author

kasturinarra commented Aug 13, 2025

@eslutsky could you please help review ? thanks !!
I have tried to add /etc/hosts entry but that kind of does not work here, and since QE vms have dns resolvable name i used that for now. May be we could discucss once you are back.

@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch 7 times, most recently from e9b49cb to 52f744f Compare August 18, 2025 07:43
${subject_alt_names_line}= Get Lines Containing String ${config_content} subjectAltNames:
${first_line}= Get Line ${subject_alt_names_line} 0
${alt_names_content}= Get Regexp Matches ${first_line} \\[(.+?)\\] 1
VAR ${alt_names_list}= ${alt_names_content}[0]
# Get the first DNS name (before the first comma)
${first_dns_name}= Split String ${alt_names_list} , 1
${dns_name}= Strip String ${first_dns_name}[0]
Should Not Be Empty ${dns_name} msg=Failed to retrieve DNS name from MicroShift config
RETURN ${dns_name}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${subject_alt_names_line}= Get Lines Containing String ${config_content} subjectAltNames:
${first_line}= Get Line ${subject_alt_names_line} 0
${alt_names_content}= Get Regexp Matches ${first_line} \\[(.+?)\\] 1
VAR ${alt_names_list}= ${alt_names_content}[0]
# Get the first DNS name (before the first comma)
${first_dns_name}= Split String ${alt_names_list} , 1
${dns_name}= Strip String ${first_dns_name}[0]
Should Not Be Empty ${dns_name} msg=Failed to retrieve DNS name from MicroShift config
RETURN ${dns_name}
${config_yaml}= Evaluate yaml.safe_load('''${config_content}''') modules=yaml
${first_dns_name}= Get From List ${config_yaml['apiServer']['subjectAltNames']} 0
Should Not Be Empty ${first_dns_name} msg=Failed to retrieve DNS name from MicroShift config
RETURN ${first_dns_name}

you can evalulate the config as yaml file and get the first item from subjectAltNames .

@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch 5 times, most recently from e017908 to f686a50 Compare August 20, 2025 11:23
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from f686a50 to bfeef46 Compare September 3, 2025 11:27
@kasturinarra
Copy link
Author

/test security

@kasturinarra
Copy link
Author

/test e2e-aws-tests-arm

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc-arm

@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch 2 times, most recently from 345336c to 1172447 Compare September 5, 2025 11:35
@kasturinarra kasturinarra marked this pull request as draft September 5, 2025 11:52
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from 1172447 to 4f7de9b Compare September 5, 2025 15:58
@kasturinarra kasturinarra marked this pull request as ready for review September 5, 2025 16:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@openshift-ci openshift-ci bot requested a review from pmtk September 5, 2025 16:07
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from 4f7de9b to 88ab792 Compare September 5, 2025 17:29
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-arm 88ab792 link true /test e2e-aws-tests-bootc-arm
ci/prow/e2e-aws-tests-bootc 88ab792 link true /test e2e-aws-tests-bootc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants