NO-ISSUE: Revert installed RPMs in AI Model Serving Containerfile #5336
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pmtk: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pmtk
force-pushed
the
revert-optional-rpms-templating-for-aims
branch
from
9d3025b to
91b9c08
Compare
| {{ range (env.Getenv "MICROSHIFT_X86_64_RPMS" | strings.Split " ") -}} | ||
| "{{ . }}-{{ env.Getenv "SOURCE_VERSION" }}" \ | ||
| {{ end -}} | ||
| "microshift-release-info-{{ env.Getenv "SOURCE_VERSION" }}" \ |
There was a problem hiding this comment.
I think microshift-release-info is not needed because it's already present in rhel96-bootc-source:latest, wdyt?
pmtk
force-pushed
the
revert-optional-rpms-templating-for-aims
branch
from
91b9c08 to
e07955f
Compare
pmtk
force-pushed
the
revert-optional-rpms-templating-for-aims
branch
from
00f0daf to
277207f
Compare
|
/retest |
|
/jira refresh |
|
@copejon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
|
@pmtk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
rhel96-bootc-source-ai-model-serving.containerfileis specialized image - it should not include unnecessary optional RPMs as images for them are not embedded.