-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-5992: Update script to use release data from konflux #5341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-5992: Update script to use release data from konflux #5341
Conversation
bca689c
to
d7ce972
Compare
import jira.client | ||
import requests | ||
import urllib3 | ||
import json | ||
import jira | ||
import yaml | ||
|
||
SERVER_URL = 'https://issues.redhat.com/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update this var to something more descriptive like JIRA_URL
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, updated !!
import jira.client | ||
import requests | ||
import urllib3 | ||
import json | ||
import jira | ||
import yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels the imports are not in order, not sure what should be the correct order but I think, for example, json
and yaml
should be closer. Can you reorganize them, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the imports as per pep8 standards and the order right now looks good.
The provided imports should be reordered and grouped into three distinct sections, separated by a blank line, as per PEP 8 guidelines.
- Standard Library Imports: These are modules that come with Python
- Third-Party Imports: These are modules from external packages that you've installed.
- Local Application/Library Specific Imports: These are modules that are part of the same project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I didn't know that about PEP 8 guidellines. It's perfect then. Thanks.
It looks really good, great work. I just want to highlight that, currently, with this approach we can not fetch the list of CVEs from the RPM advisory. The reason is that RPM is not available on brew yet, only on Errata. This script change only support the new shipment version with konflux. If we need to list the CVEs from an RPM Errata script we have to use this script from a previos repo version branch, like |
d7ce972
to
caac55d
Compare
@kasturinarra: This pull request references USHIFT-5992 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2f01176
to
a0ebcd7
Compare
a0ebcd7
to
894861f
Compare
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@agullon one question here, yesterday i saw an announcement something like below, does that mean that when we are checking for any release, we will have to use scripts from both 4.20 and 4.19 branches to support both konflux and errata releases ?
|
Which issue(s) this PR addresses: This PR addresses being able to check and retrieve ocp release data from konflux.
Closes #