Skip to content

Conversation

kasturinarra
Copy link

@kasturinarra kasturinarra commented Aug 26, 2025

Which issue(s) this PR addresses: Currently scenario.sh does not have support to run gingko test cases(openshift-qe-test-private cases), this PR enables user to run the same on the created microshift vm.

Define function in any of the scenario file using the below way

scenario_run_tests() {
    run_gingko_tests host1
}

And use the command below to run the same. when gingko is not specified it will run robot framework cases
./test/bin/scenario.sh run ./test/scenarios/presubmits/[email protected] <host>

Closes #USHIFT-5983

@openshift-ci openshift-ci bot requested review from agullon and eslutsky August 26, 2025 17:17
@kasturinarra
Copy link
Author

@ggiguash @agullon could you please help review ?

@kasturinarra kasturinarra changed the title Update scenario.sh script to run gingko tests USHIFT-5983: Update scenario.sh script to run gingko tests Aug 26, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2025

@kasturinarra: This pull request references USHIFT-5983 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses: Currently scenario.sh does not have support to run gingko test cases(openshift-qe-test-private cases), this PR enables user to run the same on the created microshift vm.

Define function in any of the scenario file using the below way

scenario_run_tests() {
   run_gingko_tests host1
}

And use the command below to run the same. when gingko is not specified it will run robot framework cases
./test/bin/scenario.sh run ./test/scenarios/presubmits/[email protected] <host>

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2025

@kasturinarra: This pull request references USHIFT-5983 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses: Currently scenario.sh does not have support to run gingko test cases(openshift-qe-test-private cases), this PR enables user to run the same on the created microshift vm.

Define function in any of the scenario file using the below way

scenario_run_tests() {
   run_gingko_tests host1
}

And use the command below to run the same. when gingko is not specified it will run robot framework cases
./test/bin/scenario.sh run ./test/scenarios/presubmits/[email protected] <host>

Closes #USHIFT-5983

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.


if ${cleanup_needed}; then
echo "Cloning openshift-tests-private repository..."
if ! git clone --depth 1 "${tests_repo_url}" "${tests_repo_dir}"; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add here an option to clone only a branch matching the release under test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@kasturinarra kasturinarra force-pushed the support_gingko_microshift_tests branch from 3e573e2 to df357b5 Compare August 28, 2025 17:30
@kasturinarra kasturinarra force-pushed the support_gingko_microshift_tests branch 4 times, most recently from 9dcc12f to da8d6ae Compare August 29, 2025 08:42
@kasturinarra
Copy link
Author

@agullon could you please help review again ? I have made the changes based on giga's suggestion here https://redhat-internal.slack.com/archives/C03CJTNLKAT/p1756448884851859, thanks !!

@agullon
Copy link
Contributor

agullon commented Aug 29, 2025

@kasturinarra I suggest you to add a Ginkgo scenario to exercise this new code, you can add it under the releases dir and it will be executed automatically when a commit is pushed into this PR.

@kasturinarra kasturinarra force-pushed the support_gingko_microshift_tests branch from da8d6ae to f763e6f Compare August 29, 2025 12:19
@agullon
Copy link
Contributor

agullon commented Aug 29, 2025

/pj-rehearse e2e-aws-tests-release e2e-aws-tests-boootc-release

@agullon
Copy link
Contributor

agullon commented Aug 29, 2025

/test ?

Copy link
Contributor

openshift-ci bot commented Aug 29, 2025

@agullon: The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving
/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-serial-rhel-eus
/test test-rpm
/test test-unit
/test verify

The following commands are available to trigger optional jobs:

/test images
/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests
pull-ci-openshift-microshift-main-e2e-aws-tests-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
pull-ci-openshift-microshift-main-images
pull-ci-openshift-microshift-main-security
pull-ci-openshift-microshift-main-test-unit
pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc-periodic-arm

@kasturinarra kasturinarra force-pushed the support_gingko_microshift_tests branch from dc9f0ff to 0a0efa5 Compare September 4, 2025 08:01
@kasturinarra
Copy link
Author

/pj-rehearse e2e-aws-tests-release e2e-aws-tests-boootc-release

@kasturinarra kasturinarra force-pushed the support_gingko_microshift_tests branch 3 times, most recently from f97a3e6 to 8869347 Compare September 4, 2025 08:19
@kasturinarra kasturinarra marked this pull request as ready for review September 4, 2025 09:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2025
@kasturinarra kasturinarra force-pushed the support_gingko_microshift_tests branch 3 times, most recently from b9ef5c4 to ab92b80 Compare September 4, 2025 10:27
@kasturinarra kasturinarra force-pushed the support_gingko_microshift_tests branch from ab92b80 to a0a18c6 Compare September 4, 2025 10:37
@kasturinarra
Copy link
Author

/pj-rehearse e2e-aws-tests-release e2e-aws-tests-boootc-release

@kasturinarra
Copy link
Author

/test e2e-aws-tests-release e2e-aws-tests-boootc-release

@kasturinarra
Copy link
Author

/test e2e-aws-tests-release

@kasturinarra
Copy link
Author

/test e2e-aws-tests-arm-release

@kasturinarra
Copy link
Author

/test e2e-aws-tests-arm-bootc-release

@ggiguash
Copy link
Contributor

ggiguash commented Sep 5, 2025

/retest-required

@ggiguash
Copy link
Contributor

ggiguash commented Sep 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-arm-bootc-release a0a18c6 link true /test e2e-aws-tests-arm-bootc-release
ci/prow/e2e-aws-tests-arm-release a0a18c6 link true /test e2e-aws-tests-arm-release
ci/prow/e2e-aws-tests-bootc-release a0a18c6 link true /test e2e-aws-tests-bootc-release
ci/prow/e2e-aws-tests-release a0a18c6 link true /test e2e-aws-tests-release

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pacevedom
Copy link
Contributor

/verified by e2e-aws-tests

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 5, 2025
@openshift-ci-robot
Copy link

@pacevedom: This PR has been marked as verified by e2e-aws-tests.

In response to this:

/verified by e2e-aws-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f243d1a and 2 for PR HEAD a0a18c6 in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants