-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-5983: Update scenario.sh script to run gingko tests #5365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
USHIFT-5983: Update scenario.sh script to run gingko tests #5365
Conversation
|
@kasturinarra: This pull request references USHIFT-5983 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kasturinarra: This pull request references USHIFT-5983 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
test/bin/scenario.sh
Outdated
|
|
||
| if ${cleanup_needed}; then | ||
| echo "Cloning openshift-tests-private repository..." | ||
| if ! git clone --depth 1 "${tests_repo_url}" "${tests_repo_dir}"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add here an option to clone only a branch matching the release under test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
3e573e2 to
df357b5
Compare
9dcc12f to
da8d6ae
Compare
|
@agullon could you please help review again ? I have made the changes based on giga's suggestion here https://redhat-internal.slack.com/archives/C03CJTNLKAT/p1756448884851859, thanks !! |
|
@kasturinarra I suggest you to add a Ginkgo scenario to exercise this new code, you can add it under the |
da8d6ae to
f763e6f
Compare
|
/pj-rehearse e2e-aws-tests-release e2e-aws-tests-boootc-release |
|
/test ? |
|
@agullon: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-tests-bootc-periodic-arm |
dc9f0ff to
0a0efa5
Compare
|
/pj-rehearse e2e-aws-tests-release e2e-aws-tests-boootc-release |
f97a3e6 to
8869347
Compare
b9ef5c4 to
ab92b80
Compare
ab92b80 to
a0a18c6
Compare
|
/pj-rehearse e2e-aws-tests-release e2e-aws-tests-boootc-release |
|
/test e2e-aws-tests-release e2e-aws-tests-boootc-release |
|
/test e2e-aws-tests-release |
|
/test e2e-aws-tests-arm-release |
|
/test e2e-aws-tests-arm-bootc-release |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kasturinarra: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by e2e-aws-tests |
|
@pacevedom: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Which issue(s) this PR addresses: Currently scenario.sh does not have support to run gingko test cases(openshift-qe-test-private cases), this PR enables user to run the same on the created microshift vm.
Define function in any of the scenario file using the below way
And use the command below to run the same. when gingko is not specified it will run robot framework cases
./test/bin/scenario.sh run ./test/scenarios/presubmits/[email protected] <host>Closes #USHIFT-5983