-
Notifications
You must be signed in to change notification settings - Fork 82
Fix deploy-olm failing on docker build without --load
#1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deploy-olm failing on docker build without --load
#1593
Conversation
This is because docker build has become aliased to docker buildx build whose default no longer load build result to docker images which mean subsequent call to `docker-push` target fails. Signed-off-by: Tiger Kaovilai <[email protected]>
--load
on build--load
on build
--load
on build--load
/test images |
/test images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kaovilai
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherry-pick oadp-1.4 |
@kaovilai: #1593 failed to apply on top of branch "oadp-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why the changes were made
This is because docker build has become aliased to docker buildx build whose default no longer load build result to docker images which mean subsequent call to
docker-push
target fails, such as whenmake deploy-olm
We are getting rid of error highlighted in red like below.
https://docs.docker.com/reference/cli/docker/buildx/build/#load
How to test the changes made
checkout and see that podman build can also accept this param and not fail. (I did, it worked.)