Skip to content

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Nov 20, 2024

Why the changes were made

This is because docker build has become aliased to docker buildx build whose default no longer load build result to docker images which mean subsequent call to docker-push target fails, such as when make deploy-olm

We are getting rid of error highlighted in red like below.

WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
/Applications/Xcode.app/Contents/Developer/usr/bin/make docker-push IMG=ttl.sh/oadp-operator-bundle-a5cd6de2:1h
docker push ttl.sh/oadp-operator-bundle-a5cd6de2:1h
-Error response from daemon: failed to find image ttl.sh/oadp-operator-bundle-a5cd6de2:1h: ttl.sh/oadp-operator-bundle-a5cd6de2:1h: image not known
-make[2]: *** [docker-push] Error 1
-make[1]: *** [bundle-push] Error 2

https://docs.docker.com/reference/cli/docker/buildx/build/#load

How to test the changes made

checkout and see that podman build can also accept this param and not fail. (I did, it worked.)

This is because docker build has become aliased to docker buildx build whose default no longer load build result to docker images which mean subsequent call to `docker-push` target fails.

Signed-off-by: Tiger Kaovilai <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@kaovilai kaovilai changed the title Newer docker cli expects --load on build Fix deploy-olm failing on expects --load on build Nov 20, 2024
@kaovilai kaovilai changed the title Fix deploy-olm failing on expects --load on build Fix deploy-olm failing on docker build without --load Nov 20, 2024
@kaovilai
Copy link
Member Author

/test images

@kaovilai
Copy link
Member Author

/test images

Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kaovilai

Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai kaovilai added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06081c0 and 2 for PR HEAD 4974e15 in total

@kaovilai
Copy link
Member Author

kaovilai commented Dec 5, 2024

/retest-required

Copy link

openshift-ci bot commented Dec 5, 2024

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 35630c7 into openshift:master Dec 5, 2024
22 checks passed
@kaovilai
Copy link
Member Author

kaovilai commented Dec 5, 2024

/cherry-pick oadp-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@kaovilai: #1593 failed to apply on top of branch "oadp-1.4":

Applying: Newer docker cli expects `--load` on build
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Newer docker cli expects `--load` on build

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants