E2E Fix: remove the finalizers on HCP to allow force delete after timeout expires #1848
Conversation
Previously, IsHCDeleted and IsHCPDeleted only returned a boolean, causing actual errors to be lost and reported as generic timeout errors. This made debugging difficult when deletion checks failed due to API errors rather than the resource still existing. Changes: - Modified IsHCDeleted to return (bool, error) - Modified IsHCPDeleted to return (bool, error) - Updated WaitForHCDeletion and WaitForHCPDeletion to handle errors - Updated test cases to handle the new error returns This provides better error visibility for troubleshooting HCP deletion timeouts. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
openshift-ci
bot
added
the
approved
|
/retest |
|
/test all |
|
@kaovilai: No presubmit jobs available for openshift/oadp-operator@oadp-dev In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
there's no test in oadp-dev |
weshayutin
changed the title
| Namespace: h.HostedCluster.Namespace, | ||
| }, hc) | ||
| if err == nil && len(hc.GetFinalizers()) > 0 { | ||
| log.Printf("\tNUKE: Removing finalizers from HostedCluster %s", hc.Name) |
There was a problem hiding this comment.
How about adding loging for what finalizers are? Something like:
log.Printf("\tNUKE: Finalizers present: %v", hc.GetFinalizers())
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/4.19-e2e-test-kubevirt-aws ci/prow/4.19-e2e-test-cli-aws ci/prow/4.19-e2e-test-aws override ordered |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.19-e2e-test-aws, ci/prow/4.19-e2e-test-cli-aws, ci/prow/4.19-e2e-test-kubevirt-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
not true, |
|
boss order transcripts. https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1753894921838309?thread_ts=1753893540.472839&cid=C0144ECKUJ0 |
Why the changes were made
The HCP / OADP e2e tests were failing and blocking work
How to test the changes made
After the time out expires on the delete call for the HC, remove finalizers and call delete.