Skip to content

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 27, 2025

This PRs builds on top of #1921 and adds one more commit with the changes described below. Please review that PR first and then the last commit from the current PR. When pull/1921 is merged the current PR needs to be rebased.

  • Add external-rosa mode for HC_BACKUP_RESTORE_MODE to support existing ROSA clusters
  • Introduce HC_NAMESPACE parameter for configurable cluster namespace management
  • Add service cluster kubeconfig support via SC_KUBECONFIG parameter for ROSA ManifestWork operations
  • Implement ManifestWork backup/deletion functionality for ROSA cluster lifecycle management
  • Add open-cluster-management.io/api dependency to support ManifestWork operations
  • Create separate OADP deployment operations for default vs ROSA scenarios
  • Skip DPA HCP plugin modification for ROSA where DPA is managed via ManifestWork
  • Add VSL_AWS_PROFILE parameter for volume snapshot location AWS profile configuration
  • Refactor backup/restore suite to use pluggable deployment strategies
  • Update test configuration to handle both regular HCP and ROSA cluster workflows

Why the changes were made

  • This is important for testing OADP hypershift plugin in ROSA and for testing bug fixes such as OCPBUGS-56430. So far it was a manual process, but this PR extends the test suite so that the whole procedure can be run automatically.

How to test the changes made

  • Steps are described in TESTING.md where a new section was added for HCP/ROSA.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
Copy link

openshift-ci bot commented Aug 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign mrnold for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur mgencur force-pushed the hcp_oadp_full_rosa branch from 2765acd to cfd509b Compare August 27, 2025 06:49
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
@mgencur mgencur changed the title feat: Enable ROSA cluster support in HCP backup/restore tests [WIP] feat: Enable ROSA cluster support in HCP backup/restore tests Aug 27, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2025
@mgencur mgencur force-pushed the hcp_oadp_full_rosa branch from cfd509b to e7ce16e Compare August 27, 2025 07:22
- Add external-rosa mode for HC_BACKUP_RESTORE_MODE to support existing
ROSA clusters
- Introduce HC_NAMESPACE parameter for configurable cluster namespace
management
- Add service cluster kubeconfig support via SC_KUBECONFIG parameter for
ROSA ManifestWork operations
- Implement ManifestWork backup/deletion functionality for ROSA cluster
lifecycle management
- Add open-cluster-management.io/api dependency to support ManifestWork
operations
- Create separate OADP deployment operations for default vs ROSA
scenarios
- Skip DPA HCP plugin modification for ROSA where DPA is managed via
ManifestWork
- Add VSL_AWS_PROFILE parameter for volume snapshot location AWS profile
configuration
- Refactor backup/restore suite to use pluggable deployment strategies
- Update test configuration to handle both regular HCP and ROSA cluster
workflows

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

openshift-ci bot commented Sep 3, 2025

@mgencur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.20-e2e-test-hcp-aws d8296b4 link false /test 4.20-e2e-test-hcp-aws
ci/prow/unit-test d8296b4 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants