OADP-6653: CloudStorage exponential backoff by removing RequeueAfter

api/v1alpha1/cloudstorage_types.go

@@ -29,6 +29,19 @@ const (
 	GCPBucketProvider   CloudStorageProvider = CloudStorageProvider(DefaultPluginGCP)
 )
 
+// CloudStorage condition constants
+const (
+	// ConditionBucketReady indicates whether the bucket exists and is ready for use
+	ConditionBucketReady = "BucketReady"
+
+	// Condition reasons for BucketReady condition
+	ReasonBucketCreated        = "BucketCreated"
+	ReasonBucketReady          = "BucketReady"
+	ReasonBucketCreationFailed = "BucketCreationFailed"
+	ReasonBucketCheckError     = "BucketCheckError"
+	ReasonSTSSecretError       = "STSSecretError"
+)
+
 type CloudStorageSpec struct {
 	// name is the name requested for the bucket (aws, gcp) or container (azure)
 	Name string `json:"name"`
@@ -63,6 +76,9 @@ type CloudStorageStatus struct {
 	// LastSyncTimestamp is the last time the contents of the CloudStorage was synced
 	// +operator-sdk:csv:customresourcedefinitions:type=status,displayName="LastSyncTimestamp"
 	LastSynced *metav1.Time `json:"lastSyncTimestamp,omitempty"`
+	// Conditions represent the latest available observations of the CloudStorage's current state
+	// +operator-sdk:csv:customresourcedefinitions:type=status
+	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }
 
 // +kubebuilder:object:root=true

bundle/manifests/oadp-operator.clusterserviceversion.yaml

@@ -394,6 +394,10 @@ spec:
       kind: CloudStorage
       name: cloudstorages.oadp.openshift.io
       statusDescriptors:
+      - description: Conditions represent the latest available observations of the
+          CloudStorage's current state
+        displayName: Conditions
+        path: conditions
       - description: LastSyncTimestamp is the last time the contents of the CloudStorage
           was synced
         displayName: LastSyncTimestamp

bundle/manifests/oadp.openshift.io_cloudstorages.yaml

@@ -99,6 +99,64 @@ spec:
             type: object
           status:
             properties:
+              conditions:
+                description: Conditions represent the latest available observations
+                  of the CloudStorage's current state
+                items:
+                  description: Condition contains details for one aspect of the current
+                    state of this API Resource.
+                  properties:
+                    lastTransitionTime:
+                      description: |-
+                        lastTransitionTime is the last time the condition transitioned from one status to another.
+                        This should be when the underlying condition changed.  If that is not known, then using the time when the API field changed is acceptable.
+                      format: date-time
+                      type: string
+                    message:
+                      description: |-
+                        message is a human readable message indicating details about the transition.
+                        This may be an empty string.
+                      maxLength: 32768
+                      type: string
+                    observedGeneration:
+                      description: |-
+                        observedGeneration represents the .metadata.generation that the condition was set based upon.
+                        For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date
+                        with respect to the current state of the instance.
+                      format: int64
+                      minimum: 0
+                      type: integer
+                    reason:
+                      description: |-
+                        reason contains a programmatic identifier indicating the reason for the condition's last transition.
+                        Producers of specific condition types may define expected values and meanings for this field,
+                        and whether the values are considered a guaranteed API.
+                        The value should be a CamelCase string.
+                        This field may not be empty.
+                      maxLength: 1024
+                      minLength: 1
+                      pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$
+                      type: string
+                    status:
+                      description: status of the condition, one of True, False, Unknown.
+                      enum:
+                      - "True"
+                      - "False"
+                      - Unknown
+                      type: string
+                    type:
+                      description: type of condition in CamelCase or in foo.example.com/CamelCase.
+                      maxLength: 316
+                      pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
+                      type: string
+                  required:
+                  - lastTransitionTime
+                  - message
+                  - reason
+                  - status
+                  - type
+                  type: object
+                type: array
               lastSyncTimestamp:
                 description: LastSyncTimestamp is the last time the contents of the
                   CloudStorage was synced

config/crd/bases/oadp.openshift.io_cloudstorages.yaml

@@ -99,6 +99,64 @@ spec:
             type: object
           status:
             properties:
+              conditions:
+                description: Conditions represent the latest available observations
+                  of the CloudStorage's current state
+                items:
+                  description: Condition contains details for one aspect of the current
+                    state of this API Resource.
+                  properties:
+                    lastTransitionTime:
+                      description: |-
+                        lastTransitionTime is the last time the condition transitioned from one status to another.
+                        This should be when the underlying condition changed.  If that is not known, then using the time when the API field changed is acceptable.
+                      format: date-time
+                      type: string
+                    message:
+                      description: |-
+                        message is a human readable message indicating details about the transition.
+                        This may be an empty string.
+                      maxLength: 32768
+                      type: string
+                    observedGeneration:
+                      description: |-
+                        observedGeneration represents the .metadata.generation that the condition was set based upon.
+                        For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date
+                        with respect to the current state of the instance.
+                      format: int64
+                      minimum: 0
+                      type: integer
+                    reason:
+                      description: |-
+                        reason contains a programmatic identifier indicating the reason for the condition's last transition.
+                        Producers of specific condition types may define expected values and meanings for this field,
+                        and whether the values are considered a guaranteed API.
+                        The value should be a CamelCase string.
+                        This field may not be empty.
+                      maxLength: 1024
+                      minLength: 1
+                      pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$
+                      type: string
+                    status:
+                      description: status of the condition, one of True, False, Unknown.
+                      enum:
+                      - "True"
+                      - "False"
+                      - Unknown
+                      type: string
+                    type:
+                      description: type of condition in CamelCase or in foo.example.com/CamelCase.
+                      maxLength: 316
+                      pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
+                      type: string
+                  required:
+                  - lastTransitionTime
+                  - message
+                  - reason
+                  - status
+                  - type
+                  type: object
+                type: array
               lastSyncTimestamp:
                 description: LastSyncTimestamp is the last time the contents of the
                   CloudStorage was synced

config/manifests/bases/oadp-operator.clusterserviceversion.yaml

@@ -403,6 +403,10 @@ spec:
       kind: CloudStorage
       name: cloudstorages.oadp.openshift.io
       statusDescriptors:
+      - description: Conditions represent the latest available observations of the
+          CloudStorage's current state
+        displayName: Conditions
+        path: conditions
       - description: LastSyncTimestamp is the last time the contents of the CloudStorage
           was synced
         displayName: LastSyncTimestamp