Skip to content

Conversation

deepakraj1997
Copy link
Contributor

No description provided.

@deepakraj1997
Copy link
Contributor Author

/test-all

Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakraj1997 Do you mind adding unit test for this scenario as well as other credential file parsing scenarios covering boundary cases ?

@deepakraj1997
Copy link
Contributor Author

deepakraj1997 commented Nov 18, 2021

@shubham-pampattiwar Thank you for reviewing, I did add a test case last time for testing profile but missed this corner case. I have added a new test case for this.

@codecov-commenter
Copy link

Codecov Report

Merging #460 (ecb89f0) into master (16f7a20) will increase coverage by 0.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   41.51%   42.08%   +0.56%     
==========================================
  Files           9        9              
  Lines        1869     1870       +1     
==========================================
+ Hits          776      787      +11     
+ Misses       1040     1033       -7     
+ Partials       53       50       -3     
Impacted Files Coverage Δ
controllers/registry.go 42.63% <100.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f7a20...ecb89f0. Read the comment docs.

@dymurray dymurray merged commit 7e3a025 into openshift:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants