Skip to content

Conversation

kaovilai
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #465 (00d273c) into master (076f149) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   41.22%   41.22%           
=======================================
  Files           9        9           
  Lines        1887     1887           
=======================================
  Hits          778      778           
  Misses       1053     1053           
  Partials       56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076f149...00d273c. Read the comment docs.

@kaovilai kaovilai marked this pull request as draft November 19, 2021 19:53
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2021
@kaovilai
Copy link
Member Author

This seems to work. Manager container is unable to start due to proxy setting

2021-11-19T19:52:24.394Z	ERROR	setup	unable to start manager	{"error": "Get \"https://172.30.0.1:443/api?timeout=32s\": proxyconnect tcp: dial tcp: lookup proxy.example.com on 172.30.0.10:53: no such host"}

@kaovilai kaovilai marked this pull request as ready for review November 19, 2021 22:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2021
@kaovilai
Copy link
Member Author

/test operator-e2e

@kaovilai kaovilai marked this pull request as draft November 23, 2021 17:12
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2021
@kaovilai kaovilai marked this pull request as ready for review November 23, 2021 17:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2021
@kaovilai
Copy link
Member Author

Seems to work detecting missing env in pods. Need to figure out what pod is missing
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/465/pull-ci-openshift-oadp-operator-master-operator-e2e/1463204484065792000#1:build-log.txt%3A257

• Failure [43.079 seconds]
Subscription Config Suite Test
/go/src/github.com/openshift/oadp-operator/tests/e2e/subscription_suite_test.go:17
  Proxy test table
  /go/src/github.com/openshift/oadp-operator/tests/e2e/subscription_suite_test.go:37
    HTTP_PROXY set [It]
    /go/src/github.com/openshift/oadp-operator/tests/e2e/subscription_suite_test.go:103
    Expected
      
        <[]v1.EnvVar | len:4, cap:4>: [
            {
                Name: "NODE_NAME",
                Value: "",
                ValueFrom: {
                    FieldRef: {
                        APIVersion: "v1",
                        FieldPath: "spec.nodeName",
                    },
                    ResourceFieldRef: nil,
                    ConfigMapKeyRef: nil,
                    SecretKeyRef: nil,
                },
            },
            {
                Name: "VELERO_NAMESPACE",
                Value: "",
                ValueFrom: {
                    FieldRef: {
                        APIVersion: "v1",
                        FieldPath: "metadata.namespace",
                    },
                    ResourceFieldRef: nil,
                    ConfigMapKeyRef: nil,
                    SecretKeyRef: nil,
                },
            },
            {
                Name: "VELERO_SCRATCH_DIR",
                Value: "/scratch",
                ValueFrom: nil,
            },
            {
                Name: "AWS_SHARED_CREDENTIALS_FILE",
                Value: "/credentials/cloud",
                ValueFrom: nil,
            },
        ]
    to contain element matching
        <v1.EnvVar>: {
            Name: "HTTP_PROXY",
            Value: "http://proxy.example.com:8080",
            ValueFrom: nil,
        }
    /go/src/github.com/openshift/oadp-operator/tests/e2e/subscription_suite_test.go:91

@kaovilai
Copy link
Member Author

Just added logs in 5745ca3 but the prior issue got resolved somehow.

@dymurray dymurray merged commit b4752ce into openshift:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants