OADP-176: Fix sensitive data exposed in registry env vars #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dymurray
reviewed
Jan 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 39.78% 38.73% -1.05%
==========================================
Files 13 13
Lines 2569 2695 +126
==========================================
+ Hits 1022 1044 +22
- Misses 1462 1570 +108
+ Partials 85 81 -4
Continue to review full report at Codecov.
|
dymurray
approved these changes
Jan 13, 2022
|
@shubham-pampattiwar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a registry secret per BSL and then updates the registry secret with the cloud provider (aws and azure) secret data, this sensitive data is then consumed by the registry deployment's env vars needed for the registry storage drivers.