Skip to content

Fix mysql/maria sample to have a sampleapp and data #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 5, 2022
Merged

Fix mysql/maria sample to have a sampleapp and data #612

merged 7 commits into from
Apr 5, 2022

Conversation

weshayutin
Copy link
Contributor

This should fix issue:
#609

This adds a mediawiki app that uses mariadb and has
data associated with it.

@weshayutin
Fix mysql/maria sample to have a sampleapp and data
451f32b 
This should fix issue:
#609

This adds a mediawiki app that uses mariadb and has
data associated with it.
@openshift-ci openshift-ci bot requested review from jwmatthews and rayfordj March 24, 2022 20:10
@weshayutin
Copy link
Contributor Author

/hold I found a bug on line 178.. I need to dynamically get the route address in the template. Looking this up

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@kaovilai
Copy link
Member

I love your dynamic on this issue.

@kaovilai
Copy link
Member

/retest

1 similar comment
@hhpatel14
Copy link
Contributor

/retest

@weshayutin
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@smg247
Copy link
Member

smg247 commented Mar 31, 2022

/retest

dymurray
dymurray approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes

@kaovilai
Copy link
Member

kaovilai commented Apr 4, 2022

/retest

2 similar comments
@kaovilai
Copy link
Member

kaovilai commented Apr 4, 2022

/retest

@weshayutin
Copy link
Contributor Author

/retest

@weshayutin
Copy link
Contributor Author

/retest once more for consistency

@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2022

@weshayutin: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test 4.7-ci-index
  • /test 4.7-images
  • /test 4.7-operator-e2e
  • /test 4.7-operator-unit-test
  • /test 4.8-ci-index
  • /test 4.8-images
  • /test 4.8-operator-e2e
  • /test 4.8-operator-unit-test
  • /test 4.9-ci-index
  • /test 4.9-images
  • /test 4.9-operator-e2e
  • /test 4.9-operator-unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-oadp-operator-master-4.7-ci-index
  • pull-ci-openshift-oadp-operator-master-4.7-images
  • pull-ci-openshift-oadp-operator-master-4.7-operator-e2e
  • pull-ci-openshift-oadp-operator-master-4.8-ci-index
  • pull-ci-openshift-oadp-operator-master-4.8-images
  • pull-ci-openshift-oadp-operator-master-4.8-operator-e2e
  • pull-ci-openshift-oadp-operator-master-4.9-ci-index
  • pull-ci-openshift-oadp-operator-master-4.9-images
  • pull-ci-openshift-oadp-operator-master-4.9-operator-e2e

In response to this:

/retest once more for consistency

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weshayutin
Copy link
Contributor Author

/test 4.8-operator-e2e

@weshayutin
Copy link
Contributor Author

/test 4.9-operator-e2e

@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2022

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@weshayutin
Copy link
Contributor Author

ok.. think we're gtg https://prow.ci.openshift.org/pr-history/?org=openshift&repo=oadp-operator&pr=612 on #612 w/ two follow up items. #619 and #622

@dymurray dymurray merged commit 58077a4 into openshift:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

@dymurray dymurray dymurray approved these changes

@jwmatthews jwmatthews Awaiting requested review from jwmatthews

@rayfordj rayfordj Awaiting requested review from rayfordj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weshayutin @kaovilai @hhpatel14 @smg247 @dymurray