Skip to content

Adding function to verify Backup / Restore data #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2022
Merged

Adding function to verify Backup / Restore data #624

merged 4 commits into from
May 2, 2022

Conversation

deepakraj1997
Copy link
Contributor

@deepakraj1997 deepakraj1997 commented Apr 6, 2022 •
edited by kaovilai
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from mperetzred and rayfordj April 6, 2022 17:08
@weshayutin
Copy link
Contributor

@deepakraj1997 nice start dude!

@deepakraj1997
Copy link
Contributor Author

/retest

weshayutin
weshayutin reviewed Apr 20, 2022
View reviewed changes
tests/e2e/backup_restore_suite_test.go Outdated
@@ -47,6 +47,7 @@ var _ = Describe("AWS backup restore tests", func() {

parksAppReady := VerificationFunction(func(ocClient client.Client, namespace string) error {
Eventually(IsDCReady(ocClient, "parks-app", "restify"), timeoutMultiplier*time.Minute*10, time.Second*10).Should(BeTrue())
// err := VerifyBackUpRestoreData(artifact_dir, namespace, "restify", "parks-app") // TODO: VERIFY PARKS APP DATA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks... looking at the parks app.. the last commit was in 2016. I'm a little suspicious of this app. https://github.com/ryanj/restify-mongodb-parks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added the issue in the description although we could verify the data if we add a wait function.

@deepakraj1997 deepakraj1997 marked this pull request as ready for review April 20, 2022 14:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
@openshift-ci openshift-ci bot requested a review from jwmatthews April 20, 2022 14:48
@deepakraj1997
Copy link
Contributor Author

/retest

1 similar comment
@deepakraj1997
Copy link
Contributor Author

/retest

@weshayutin
Copy link
Contributor

+1 to making this part of the validation VERY resiliant

kaovilai
kaovilai requested changes Apr 22, 2022
View reviewed changes
tests/e2e/lib/apps.go Outdated
@@ -197,3 +203,54 @@ func RunMustGather(oc_cli string, artifact_dir string) error {
_, err := cmd.Output()
return err
}

func VerifyBackUpRestoreData(artifact_dir string, namespace string, routeName string, app string) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func VerifyBackUpRestoreData(artifact_dir string, namespace string, routeName string, app string) error {
func VerifyBackupRestoreData(artifact_dir string, namespace string, routeName string, app string) error {

This was referenced Apr 22, 2022
Closed
Merged
@kaovilai
Copy link
Member

/retest

@kaovilai kaovilai changed the title Adding function to verify BackUp / Restore data Adding function to verify Backup / Restore data Apr 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2022

@deepakraj1997: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepakraj1997 deepakraj1997 merged commit a5c842e into openshift:master May 2, 2022
kaovilai pushed a commit that referenced this pull request May 3, 2022
@weshayutin
replace the parks-app with todolist on mongo (#649)
dfa7af9 
* created a version of todolist for mongo
* ensure the manifest builds and triggers just like
the parks-app did
* adv is that the same app api can be used to add
data to the db and check after restore. Related PR
#624

Resolves: #646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshayutin weshayutin weshayutin left review comments

@kaovilai kaovilai kaovilai approved these changes

@mperetzred mperetzred Awaiting requested review from mperetzred

@rayfordj rayfordj Awaiting requested review from rayfordj

@jwmatthews jwmatthews Awaiting requested review from jwmatthews

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: OADP tests/e2e backup and restore tests NEED to validate data matches before and after restore.
3 participants
@deepakraj1997 @weshayutin @kaovilai