go 1.18 make kustomize fix, GH Actions: go 1.18, submit-coverage fix
#716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustomize v4 can be installed via go install Github Actions: go-test go version bump to 1.18 kustomize v3->v4 breaking changes related to supported url types don't affect our repo
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 37.27% 37.10% -0.18%
==========================================
Files 14 15 +1
Lines 2940 3099 +159
==========================================
+ Hits 1096 1150 +54
- Misses 1761 1849 +88
- Partials 83 100 +17
Continue to review full report at Codecov.
|
|
cherrypicking into #710 |
|
/retest |
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dymurray
approved these changes
Jun 8, 2022
kaovilai
commented
Jun 8, 2022
| @[ -f $(1) ] || { \ | ||
| set -e ;\ | ||
| TMP_DIR=$$(mktemp -d) ;\ | ||
| cd $$TMP_DIR ;\ | ||
| go mod init tmp ;\ | ||
| echo "Downloading $(2)" ;\ | ||
| GOBIN=$(PROJECT_DIR)/bin go get $(2) ;\ | ||
| GOBIN=$(PROJECT_DIR)/bin go install -mod=mod $(2) ;\ |
There was a problem hiding this comment.
Just a note that -mod=mod here is required for go 1.16
kaovilai
added a commit
that referenced
this pull request
Apr 12, 2023
#716) * Github Actions: go-test go version bump to 1.18 kustomize v4 can be installed via go install Github Actions: go-test go version bump to 1.18 kustomize v3->v4 breaking changes related to supported url types don't affect our repo * -mod=mod
kaovilai
added a commit
that referenced
this pull request
Apr 12, 2023
* Update ci-Dockerfile to go 1.19 for oadp-1.0 * remove TODO comment * go 1.18 `make kustomize` fix, GH Actions: go 1.18, submit-coverage fix (#716) * Github Actions: go-test go version bump to 1.18 kustomize v4 can be installed via go install Github Actions: go-test go version bump to 1.18 kustomize v3->v4 breaking changes related to supported url types don't affect our repo * -mod=mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kustomize v4 can be installed via go install
Github Actions: go-test go version bump to 1.18
kustomize v3->v4 breaking changes related to supported url types don't affect our repo