OADP-572 updating CRDs and velero go mod dep for konveyor-1.9 branch #738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
=======================================
Coverage 36.96% 36.96%
=======================================
Files 16 16
Lines 3219 3219
=======================================
Hits 1190 1190
Misses 1926 1926
Partials 103 103
Continue to review full report at Codecov.
|
|
/retest-required |
sseago
changed the title
|
Once oadp-1.1 branch is created, the velero and plugins image tags need to be moved back to |
once OADP release branch is created, the image tags need to be pointed back at latest
| @@ -831,19 +831,19 @@ spec: | |||
| provider: | |||
| name: Red Hat | |||
| relatedImages: | |||
| - image: quay.io/konveyor/velero:latest | |||
| - image: quay.io/konveyor/velero:konveyor-1.9 | |||
There was a problem hiding this comment.
@sseago do we want change the image tags from latest in master ?
There was a problem hiding this comment.
@shubham-pampattiwar Yes -- for 2 reasons:
- konveyor-dev is currently at the point just before 1.9 was branched, but there's a bug with downloadrequests there that was fixed on 1.9 (and probably also on main)
- We can't use current main since there are not-for-1.9 CRD changes there already
Once oadp-1.1 branches are created in a month or so we'll re-point oadp master to latest.
There was a problem hiding this comment.
The downloadrequest issue is why ci tests were failing with the earlier version of this PR pointing to latest.
|
/retest |
|
@sseago please review and merge sseago#1 to fix e2e for vmware-tanzu/velero@a69bd8b |
allow empty volumesnapshotlist
|
@sseago: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dymurray
changed the title
dymurray
changed the title
|
@dymurray all tests passed. I'm merging this now. |
No description provided.