Skip to content

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jul 27, 2022

OADP-648

We want to leave empty the resource limits to prevent a user from failing backups/restores due to these limits and they can always adjust as necessary.

@codecov-commenter
Copy link

Codecov Report

Merging #773 (899b238) into master (5b41bea) will decrease coverage by 2.65%.
The diff coverage is 18.62%.

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   36.96%   34.31%   -2.66%     
==========================================
  Files          16       16              
  Lines        3219     2844     -375     
==========================================
- Hits         1190      976     -214     
+ Misses       1926     1778     -148     
+ Partials      103       90      -13     
Impacted Files Coverage Δ
controllers/datamover.go 30.30% <0.00%> (-4.48%) ⬇️
controllers/registry.go 29.23% <0.00%> (-10.97%) ⬇️
pkg/common/common.go 100.00% <ø> (ø)
pkg/credentials/credentials.go 23.69% <ø> (+0.28%) ⬆️
controllers/velero.go 48.61% <67.85%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925f578...899b238. Read the comment docs.

@kaovilai kaovilai changed the title OADP-648 Don't set default resource limits OADP-648 Don't set default pod resource limits Jul 27, 2022
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VISIACK

Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaovilai Do we want to document this at least in OADP upstream that we are only setting requests and not limits, and that this differs from the upstream Velero configuration.

@kaovilai
Copy link
Member Author

Sure thing. The resource limits doc?

@kaovilai
Copy link
Member Author

/test 4.8-operator-e2e-azure

Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @kaovilai VISIACK

@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants