-
Notifications
You must be signed in to change notification settings - Fork 82
OADP-648 Don't set default pod resource limits #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 36.96% 34.31% -2.66%
==========================================
Files 16 16
Lines 3219 2844 -375
==========================================
- Hits 1190 976 -214
+ Misses 1926 1778 -148
+ Partials 103 90 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VISIACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaovilai Do we want to document this at least in OADP upstream that we are only setting requests and not limits, and that this differs from the upstream Velero configuration.
Sure thing. The resource limits doc? |
/test 4.8-operator-e2e-azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @kaovilai VISIACK
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
OADP-648
We want to leave empty the resource limits to prevent a user from failing backups/restores due to these limits and they can always adjust as necessary.