updating plugin/velero images to use 1.0 branches. #832
Conversation
|
Replacing env with RELATED_IMAGE requires velero.go changes |
sseago
force-pushed
the
update-velero-images
branch
from
fa3d5fa to
b104301
Compare
|
Missing registry env sseago#5 |
update RELATED_IMAGE for registry image ENV. CSV name version update.
|
/retest |
There was a problem hiding this comment.
Off to a strong start
- We're already building 1.0.5 images for the next OADP 1.0.z release
- We're no longer adding 1.0.z to
stable; 1.0.3 was the last. - The *_test.go files are still using
REGISTRY, PROJECT, _REPO, _TAGinstead ofRELATED_IMAGE_
I realize some of my comments throughout the files are generated using the Makefile, but I wanted to highlight them as I came across them for posterity.
Thanks!
| - name: RELATED_IMAGE_VELERO_PLUGIN_FOR_CSI | ||
| value: quay.io/konveyor/velero-plugin-for-csi:oadp-1.0 | ||
| - name: RELATED_IMAGE_KUBEVIRT_VELERO_PLUGIN | ||
| value: quay.io/konveyor/kubevirt-velero-plugin:v0.2.0 |
| - name: RELATED_IMAGE_VELERO_PLUGIN_FOR_CSI | ||
| value: quay.io/konveyor/velero-plugin-for-csi:oadp-1.0 | ||
| - name: RELATED_IMAGE_KUBEVIRT_VELERO_PLUGIN | ||
| value: quay.io/konveyor/kubevirt-velero-plugin:v0.2.0 |
Co-authored-by: RayfordJ <[email protected]>
Co-authored-by: RayfordJ <[email protected]>
Co-authored-by: RayfordJ <[email protected]>
Co-authored-by: RayfordJ <[email protected]>
|
Can't push to remote but can edit one file at a time in web editor :D. |
|
need to update https://github.com/openshift/release/blob/master/ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.0__4.7.yaml#L79 to stable-1.0 to unblock e2e. |
updating! |
|
/retest |
|
@sseago: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This PR unblocks oadp-1.0 e2e :) .. let the retests begin :D |
No description provided.