OTA-1575: pkg/cli/admin/upgrade/recommend: "accepted ... via ConditionalUpdateRisk" #2040
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request references OTA-1575 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
hi @wking I tried 2 scenarios, the reasons not maps to a risk.
After accept Scenario 1, AdminAckRequired: Scenario 2, MultipleReasons: |
…isk" Make it clearer how '--accept ConditionalUpdateRisk' maps to a risk like NonZonalAzureMachineSetScaling getting accepted, by turning the previous: Reason: accepted NonZonalAzureMachineSetScaling into: Reason: accepted NonZonalAzureMachineSetScaling via ConditionalUpdateRisk Eventually we'll have an API that allows us to use the conditional-update risk name itself (e.g. '--accept NonZonalAzureMachineSetScaling') [1,2], but this 'via...' context will hopefully help avoid confusion in the meantime. [1]: openshift/enhancements#1807 [2]: https://issues.redhat.com/browse/OTA-1543
wking
force-pushed
the
accepted-via-ConditionalUpdateRisk
branch
from
37b8da4 to
7698d9a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you @wking It works fine. By default, recommend with --version: --accept ConditionalUpdateRisk --accept FailedToCompletePrecheck --accept ConditionalUpdateRisk --quiet accept all risks: |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@wking: This pull request references OTA-1575 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
One more test: accept all risks without quiet: |
|
/cc |
1 similar comment
|
The e2e-agnostic-ovn-cmd |
|
Seems like the wildfly bit is from here, based on this fixture. But I'm not sure how to debug the but that namespace was cleaned up as part of the test-case's teardown: so there's not much left in gathered artifacts to talk about what went wrong. The test-case stdout also includes: but none of those 6 Events sound like they're talking about ImageStreams or Builds to me. |
2 similar comments
7 similar comments
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 9808979
into
openshift:main
Make it clearer how
--accept ConditionalUpdateRiskmaps to a risk likeNonZonalAzureMachineSetScalinggetting accepted, by turning the previous:into:
Eventually we'll have an API that allows us to use the conditional-update risk name itself (e.g.
--accept NonZonalAzureMachineSetScaling, OTA-1543, openshift/enhancements#1807), but thisvia...context will hopefully help avoid confusion in the meantime.