-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#11515:Add MicroShift observability via OTEL integration #92758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9b277d1
to
da14a60
Compare
74206fa
to
d9c409d
Compare
@pmtk the configuration for the medium and small service configs are not included in Jon's note document. Will you provide that information? Thanks! |
10b5495
to
ceab112
Compare
@pmtk What are your thoughts on including configs for all 3 of the service profiles? I included 'large' (default) just in case the config was set to another one and later needed to go back to large. Thx! |
We'll add the to the RPM as well, but I think it won't hurt to include them in the docs (though they might get outdated, so we need to remember about them...).
|
ceab112
to
1ec7ca7
Compare
35d0cd9
to
bea03e5
Compare
/test validate-asciidoc |
2a14454
to
f3d8592
Compare
@pmtk I changed the order of a couple of modules for clarity. Will you verify that I captured your comments correctly for the various configurations? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just change the variable name to match openshift/microshift#4903 and I think we're good
ff49ccf
to
ae47bdb
Compare
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good work, but I have added some comments that should be addressed before merging, particularly around breaking up the large config module into multiple modules.
63cbb7e
to
8301baa
Compare
/label merge-review-needed |
modules/microshift-otel-config.adoc
Outdated
[id="microshift-otel-config_{context}"] | ||
= Configuring {microshift-short} Observability | ||
|
||
You must configure {microshift-short} Observability after it is installed by specifying a valid endpoint. If an endpoint is not specified, {microshift-short} Observability will not start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future consideration:
You must configure {microshift-short} Observability after it is installed by specifying a valid endpoint. If an endpoint is not specified, {microshift-short} Observability will not start. | |
You must configure {microshift-short} Observability after it is installed by specifying a valid endpoint. If an endpoint is not specified, {microshift-short} Observability does not start. |
8301baa
to
be1fead
Compare
|
||
The `opentelemetry-collector.yaml` file includes specific parameters that are used to collect data for monitoring the system resources. All warnings for cluster events are included in the collected data. {microshift-short} Observability collects and transmits data for the following resources: | ||
|
||
* CPU, memory, disk, and network metrics of containers, pods, and node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably plural?
* CPU, memory, disk, and network metrics of containers, pods, and node | |
* CPU, memory, disk, and network metrics of containers, pods, and nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, MicroShift is single-node.
be1fead
to
fb0e4ce
Compare
* Kubernetes events | ||
* Host CPU, memory, disk, and network metrics | ||
* System journals for certain {microshift-short} services, and dependencies | ||
* Metrics exposed by pods that have `prometheus.io/scrape`: `true` annotation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Metrics exposed by pods that have `prometheus.io/scrape`: `true` annotation | |
* Metrics exposed by pods that have the `prometheus.io/scrape`: `true` annotation |
:_mod-docs-content-type: PROCEDURE | ||
[id="microshift-otel-config-large_{context}"] | ||
= Selecting a large configuration | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because these are procedural modules, I think that they need an introductory paragraph: https://redhat-documentation.github.io/modular-docs/#con-creating-procedure-modules_writing-mod-docs
protocol: http/protobuf | ||
endpoint: http://${env:OTEL_BACKEND}:4318 <2> | ||
---- | ||
<1> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the `microshift-observability` service logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above example, OTLP-compatible endpoint configuration, uses the same callout (<1>) so that it doesn't repeat the same information. In this example, you use 2 callouts (<1>, <2>), and then the same information is repeated.
Could you swap line 120 to <1> and then remove line 123?
:_mod-docs-content-type: PROCEDURE | ||
[id="microshift-otel-config-medium_{context}"] | ||
= Selecting a medium configuration | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same sentiments here about needing an introduction
endpoint: http://${env:OTEL_BACKEND}:4318 <2> | ||
---- | ||
<1> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the `microshift-observability` service logs. | ||
<2> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the `microshift-observability` service logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same sentiments here as above.
:_mod-docs-content-type: PROCEDURE | ||
[id="microshift-otel-config-small_{context}"] | ||
= Selecting a small configuration | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same sentiment here about an introduction.
endpoint: http://${env:OTEL_BACKEND}:4318 <2> | ||
---- | ||
<1> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the {microshift-short} service logs. | ||
<2> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the {microshift-short} service logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thought here as above.
$ sudo systemctl start microshift-observability | ||
---- | ||
|
||
. Restart {microshift-short} after the initial installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we provide a command here? is it the same command as in "Restarting MicroShift Observability" ? But that module is commented out, so maybe some people wouldn't know how to do this.
Or maybe they would! Just a thought/comment.
60ea6cb
to
bd5a6b4
Compare
@tmalove: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherry-pick enterprise-4.19 |
@stevsmit: new pull request created: #94714 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@stevsmit: #92758 failed to apply on top of branch "enterprise-4.18":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19+
Issue:
OSDOCS-11515 updated 5/30/25
Link to docs preview:
Using MicroShift Observability (Updated 6/12/25)
Installing and enabling MicroShift Observability (Updated 5/29/25)
QE review: