Skip to content

Conversation

tmalove
Copy link
Contributor

@tmalove tmalove commented Apr 30, 2025

Version(s):
4.19+
Issue:
OSDOCS-11515 updated 5/30/25

Link to docs preview:
Using MicroShift Observability (Updated 6/12/25)
Installing and enabling MicroShift Observability (Updated 5/29/25)

QE review:

  • [x ] QE has approved this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 30, 2025

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from 9b277d1 to da14a60 Compare May 5, 2025 03:34
@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from 74206fa to d9c409d Compare May 6, 2025 03:26
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2025
@tmalove
Copy link
Contributor Author

tmalove commented May 8, 2025

@pmtk the configuration for the medium and small service configs are not included in Jon's note document. Will you provide that information? Thanks!

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from 10b5495 to ceab112 Compare May 8, 2025 05:12
@tmalove
Copy link
Contributor Author

tmalove commented May 8, 2025

@pmtk What are your thoughts on including configs for all 3 of the service profiles? I included 'large' (default) just in case the config was set to another one and later needed to go back to large. Thx!

@pmtk
Copy link
Member

pmtk commented May 8, 2025

@pmtk What are your thoughts on including configs for all 3 of the service profiles? I included 'large' (default) just in case the config was set to another one and later needed to go back to large. Thx!

We'll add the to the RPM as well, but I think it won't hurt to include them in the docs (though they might get outdated, so we need to remember about them...).

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from ceab112 to 1ec7ca7 Compare May 12, 2025 04:10
@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from 35d0cd9 to bea03e5 Compare May 16, 2025 03:59
@tmalove
Copy link
Contributor Author

tmalove commented May 20, 2025

/test validate-asciidoc

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch 2 times, most recently from 2a14454 to f3d8592 Compare May 22, 2025 05:05
@tmalove
Copy link
Contributor Author

tmalove commented May 22, 2025

@pmtk I changed the order of a couple of modules for clarity. Will you verify that I captured your comments correctly for the various configurations? Thanks!

Copy link
Member

@pmtk pmtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just change the variable name to match openshift/microshift#4903 and I think we're good

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from ff49ccf to ae47bdb Compare May 23, 2025 02:56
@tmalove
Copy link
Contributor Author

tmalove commented May 28, 2025

/retest

@pmtk
Copy link
Member

pmtk commented May 28, 2025

/lgtm

@abrennan89 abrennan89 self-assigned this Jun 9, 2025
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good work, but I have added some comments that should be addressed before merging, particularly around breaking up the large config module into multiple modules.

@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 10, 2025
@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from 63cbb7e to 8301baa Compare June 12, 2025 00:12
@tmalove
Copy link
Contributor Author

tmalove commented Jun 12, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 12, 2025
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 12, 2025
[id="microshift-otel-config_{context}"]
= Configuring {microshift-short} Observability

You must configure {microshift-short} Observability after it is installed by specifying a valid endpoint. If an endpoint is not specified, {microshift-short} Observability will not start.
Copy link
Member

@stevsmit stevsmit Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future consideration:

Suggested change
You must configure {microshift-short} Observability after it is installed by specifying a valid endpoint. If an endpoint is not specified, {microshift-short} Observability will not start.
You must configure {microshift-short} Observability after it is installed by specifying a valid endpoint. If an endpoint is not specified, {microshift-short} Observability does not start.

https://spaces.redhat.com/display/CCSENABLE/Future+tense

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from 8301baa to be1fead Compare June 12, 2025 15:20

The `opentelemetry-collector.yaml` file includes specific parameters that are used to collect data for monitoring the system resources. All warnings for cluster events are included in the collected data. {microshift-short} Observability collects and transmits data for the following resources:

* CPU, memory, disk, and network metrics of containers, pods, and node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably plural?

Suggested change
* CPU, memory, disk, and network metrics of containers, pods, and node
* CPU, memory, disk, and network metrics of containers, pods, and nodes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, MicroShift is single-node.

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from be1fead to fb0e4ce Compare June 12, 2025 15:22
* Kubernetes events
* Host CPU, memory, disk, and network metrics
* System journals for certain {microshift-short} services, and dependencies
* Metrics exposed by pods that have `prometheus.io/scrape`: `true` annotation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Metrics exposed by pods that have `prometheus.io/scrape`: `true` annotation
* Metrics exposed by pods that have the `prometheus.io/scrape`: `true` annotation

:_mod-docs-content-type: PROCEDURE
[id="microshift-otel-config-large_{context}"]
= Selecting a large configuration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these are procedural modules, I think that they need an introductory paragraph: https://redhat-documentation.github.io/modular-docs/#con-creating-procedure-modules_writing-mod-docs

protocol: http/protobuf
endpoint: http://${env:OTEL_BACKEND}:4318 <2>
----
<1> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the `microshift-observability` service logs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above example, OTLP-compatible endpoint configuration, uses the same callout (<1>) so that it doesn't repeat the same information. In this example, you use 2 callouts (<1>, <2>), and then the same information is repeated.

Could you swap line 120 to <1> and then remove line 123?

:_mod-docs-content-type: PROCEDURE
[id="microshift-otel-config-medium_{context}"]
= Selecting a medium configuration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sentiments here about needing an introduction

endpoint: http://${env:OTEL_BACKEND}:4318 <2>
----
<1> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the `microshift-observability` service logs.
<2> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the `microshift-observability` service logs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sentiments here as above.

:_mod-docs-content-type: PROCEDURE
[id="microshift-otel-config-small_{context}"]
= Selecting a small configuration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sentiment here about an introduction.

endpoint: http://${env:OTEL_BACKEND}:4318 <2>
----
<1> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the {microshift-short} service logs.
<2> Replace the variable `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. Any unreachable endpoint is reported in the {microshift-short} service logs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thought here as above.

$ sudo systemctl start microshift-observability
----

. Restart {microshift-short} after the initial installation.
Copy link
Member

@stevsmit stevsmit Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide a command here? is it the same command as in "Restarting MicroShift Observability" ? But that module is commented out, so maybe some people wouldn't know how to do this.

Or maybe they would! Just a thought/comment.

@tmalove tmalove force-pushed the ms-osdocs-11515-tlove branch from 60ea6cb to bd5a6b4 Compare June 12, 2025 16:27
Copy link

openshift-ci bot commented Jun 12, 2025

@tmalove: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@stevsmit stevsmit merged commit a2ad03a into openshift:main Jun 12, 2025
2 checks passed
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.19

@openshift-cherrypick-robot

@stevsmit: new pull request created: #94714

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: #92758 failed to apply on top of branch "enterprise-4.18":

Applying: add new file microshift-telemetry-service
.git/rebase-apply/patch:326: trailing whitespace.
----                
.git/rebase-apply/patch:419: trailing whitespace.
You can specify any OpenTelemetry Protocol (OTLP)-compatible endpoint for each configuration before starting {microshift-short}. 
.git/rebase-apply/patch:447: trailing whitespace.
# ...                
.git/rebase-apply/patch:448: trailing whitespace.
----  
.git/rebase-apply/patch:449: trailing whitespace.
<1> Replace `${env:OTEL_BACKEND}` with the IP address or host name of the remote back end. This IP address resolves to the local node's host name. An unreachable endpoint is reported in the {microshift-short} service logs.    
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map_ms.yml
M	microshift_install_rpm_opt/microshift-install-optional-rpms.adoc
Falling back to patching base and 3-way merge...
Auto-merging microshift_install_rpm_opt/microshift-install-optional-rpms.adoc
CONFLICT (content): Merge conflict in microshift_install_rpm_opt/microshift-install-optional-rpms.adoc
Auto-merging _topic_maps/_topic_map_ms.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 add new file microshift-telemetry-service

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants