Skip to content

OADP-4005: Add CloudStorage API support #98366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OADP-4005: Add CloudStorage API support #98366

wants to merge 1 commit into from
+0 −29

Conversation

vashirova
Copy link
Member

@vashirova vashirova commented Sep 2, 2025 •
edited
Loading

Version(s):
OCP 4.19-4.20

Issue:
OADP-4005

Link to docs preview:
Technology Preview admonitions for CloudStorage API removed from the following chapters:

Reviews:

  • QE has approved this change.
  • Vale validation with AsciiDocDITA package done - not applicable.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19+

Issue:
OADP-4005

Link to docs preview:

  1. Remove Technology Preview admonitions for CloudStorage API:
  2. Add instructions on how to configure it: TBD.

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 2, 2025 •
edited
Loading

🤖 Tue Sep 02 16:50:17 - Prow CI generated the docs preview:

https://98366--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html
https://98366--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html
https://98366--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-mcg.html
https://98366--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-ocs.html
https://98366--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/index.html
https://98366--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html
https://98366--ocpdocs-pr.netlify.app/openshift-rosa/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19+

Issue:
OADP-4005

Link to docs preview:

  1. Technology Preview admonitions for CloudStorage API removed from the following chapters:
  1. Add instructions on how to configure it: TBD.

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19+

Issue:
OADP-4005

Link to docs preview:

  1. Technology Preview admonitions for CloudStorage API removed from the following chapters:
  1. Add instructions on how to configure it: TBD.

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vashirova
Copy link
Member Author

Hi @weshayutin and/or @kaovilai, could you please review these changes and reply to the following questions? This is related to CloudStorage API.

  1. Is this feature applicable for OADP 1.5.1+ only?
  2. I have removed all mentions of CloudStorage API as a Technology Preview from the following chapters, is this correct?
  1. We also have mentions of CloudStorage API as a Technology Preview in the following chapters, do I understand correctly those should be also deleted?
  1. Do we already have ready-to-be-referenced instructions on how to set up it?

Thanks!

@weshayutin
Copy link

Hi @weshayutin and/or @kaovilai, could you please review these changes and reply to the following questions? This is related to CloudStorage API.

  1. Is this feature applicable for OADP 1.5.1+ only?
  2. I have removed all mentions of CloudStorage API as a Technology Preview from the following chapters, is this correct?

Correct 1.5.1+ only

  1. We also have mentions of CloudStorage API as a Technology Preview in the following chapters, do I understand correctly those should be also deleted?

Correct, cloudstorage api is finally supported and NOT tech preview.

  1. Do we already have ready-to-be-referenced instructions on how to set up it?

We will want to tear out and keep the following and build a few steps in the doc based on instructions from @kaovilai

The CloudStorage API, which automates the creation of a bucket for object storage

@kaovilai please be sure to add steps with regards to how a user would utilize the cloudstorage api

Thanks!

@vashirova vashirova force-pushed the OADP-4005-CloudStorage-api branch from 768b4d9 to d12ad01 Compare September 2, 2025 16:36
@vashirova
Copy link
Member Author

/label OADP

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Sep 2, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 2, 2025

@vashirova: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19+

Issue:
OADP-4005

Link to docs preview:

  1. Technology Preview admonitions for CloudStorage API removed from the following chapters:
  1. Add instructions on how to configure it: TBD.

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vashirova
Copy link
Member Author

Thank you @weshayutin! All Technology Preview notes are now removed:

Await config steps from @kaovilai.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19+

Issue:
OADP-4005

Link to docs preview:

  1. Technology Preview admonitions for CloudStorage API removed from the following chapters:
  1. Add instructions on how to configure CloudStorage API: TBD.

Reviews:

  • QE has approved this change.
  • Vale validation with AsciiDocDITA package done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kaovilai
kaovilai reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see openshift/oadp-operator#1925 for CloudStorage API docs for common case and each provider.

Please review there any confusion you might have.

@kaovilai kaovilai mentioned this pull request Sep 2, 2025
Open
@weshayutin
Copy link

@kaovilai reading through openshift/oadp-operator#1925 which is great. We do not have capacity atm to full doc this feature. For now do you think if we doc'd oc explain CloudStorage and

backupLocations:
  - name: default
    bucket:
      provider: aws
      cloudStorageRef:
        name: aws-backup-storage

Do you think that would be the bare minimum? What would be required for the bare minimum IYHO

@kaovilai
Copy link
Member

kaovilai commented Sep 2, 2025

From slack, consensus is no prod doc for now, just removal of TechPreview.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19+

Issue:
OADP-4005

Link to docs preview:
Technology Preview admonitions for CloudStorage API removed from the following chapters:

Reviews:

  • QE has approved this change.
  • Vale validation with AsciiDocDITA package done - not applicable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vashirova
Copy link
Member Author

Thank you @kaovilai!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19-4.20

Issue:
OADP-4005

Link to docs preview:
Technology Preview admonitions for CloudStorage API removed from the following chapters:

Reviews:

  • QE has approved this change.
  • Vale validation with AsciiDocDITA package done - not applicable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

akarol
akarol reviewed Sep 4, 2025
View reviewed changes
backup_and_restore/index.adoc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2025 •
edited by openshift-ci bot
Loading

@vashirova: This pull request references OADP-4005 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
OCP 4.19-4.20

Issue:
OADP-4005

Link to docs preview:
Technology Preview admonitions for CloudStorage API removed from the following chapters:

Reviews:

  • QE has approved this change.
  • Vale validation with AsciiDocDITA package done - not applicable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PrasadJoshi12
Copy link
Contributor

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@shdeshpa07
Copy link
Contributor

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@akarol akarol akarol left review comments

@kaovilai kaovilai kaovilai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@PrasadJoshi12 PrasadJoshi12

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OADP Label for all OADP PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vashirova @openshift-ci-robot @ocpdocs-previewbot @weshayutin @kaovilai @PrasadJoshi12 @shdeshpa07 @akarol