Skip to content

Enter key no longer submits image search in deploy-image component #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spadgett opened this issue Jun 14, 2017 · 4 comments
Closed

Enter key no longer submits image search in deploy-image component #1703

spadgett opened this issue Jun 14, 2017 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@spadgett
Copy link
Member

Enter used to trigger a search. Now you need to click the magnifying glass.

@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Jun 14, 2017
@jwforres
Copy link
Member

looks like form and ng-form behave differently when it comes to enter key submission :-\

I know there was a reason we switched it to ng-form in my PR but I can't remember why now

@jwforres
Copy link
Member

It's not very clean but I can work around it by adding a ng-keyup="$event.keyCode === 13 && findImage() on the text input

@jwforres
Copy link
Member

apparently ng-form is not supposed to be used in place of form but nested underneath form, see angular/angular.js#2513 (comment)

@spadgett
Copy link
Member Author

We were using it because there is an outer form in the dialog and you can't nest form elements. Enter seems to work OK in the dialog. Maybe we need an outer form for the non-dialog page.

I believe we have the same problem with process-template as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Development

No branches or pull requests

2 participants